GNOME Bugzilla – Bug 703565
network: Fix a recursion issue when updating VPN
Last modified: 2013-07-03 17:55:38 UTC
_updateIcon should not attempt to sync any active connections, as the icon-changed signal can be emitted in response to something done during _syncActiveConnection. In the case of VPN, removeActiveConnection would cause an icon-changed signal to be emitted immediately, but the state would not be updated, causing us to call removeActiveConnection over and over. Explicitly sync all active connections when we know it needs to be done, and simply make _updateIcon synchronize with the current device's icon.
Created attachment 248339 [details] [review] network: Fix a recursion issue when updating VPN
Review of attachment 248339 [details] [review]: Looks good.
Attachment 248339 [details] pushed as ccba18a - network: Fix a recursion issue when updating VPN