After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703399 - v4l2: don't extract data from caps twice
v4l2: don't extract data from caps twice
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.1.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 707039 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-01 15:25 UTC by Michael Olbrich
Modified: 2013-08-30 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.37 KB, patch)
2013-07-01 15:32 UTC, Michael Olbrich 		committed Details | Review
patch (2.37 KB, application/octet-stream)
2013-07-01 15:25 UTC, Michael Olbrich 		  Details
patch (2.37 KB, patch)
2013-07-01 15:33 UTC, Michael Olbrich 		none Details | Review

Description Michael Olbrich 2013-07-01 15:25:38 UTC 
Created attachment 248158 [details]
patch

gst_video_info_from_caps() always extract width, height, interlace mode and
framerate now. It is no longer necessary to do it again for encoded
formats.
Comment 1 Michael Olbrich 2013-07-01 15:32:26 UTC 
Created attachment 248157 [details] [review]
patch
Comment 2 Michael Olbrich 2013-07-01 15:33:48 UTC 
Created attachment 248159 [details] [review]
patch
Comment 3 Michael Olbrich 2013-07-01 15:39:45 UTC 
sorry about attaching the patch multiple times. My browser was doing strange things and I guess I was a bit impatient and tried to attach the patch again...
Comment 4 Sebastian Dröge (slomo) 2013-07-02 08:10:28 UTC 
Good catch :)

commit 5c99fefa0475897efdfe8257d1d8ce026fac9107
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Mon Jul 1 16:55:01 2013 +0200

    v4l2: don't extract data from caps twice
    
    gst_video_info_from_caps() always extract width, height, interlace mode and
    framerate now. It is no longer necessary to do it again for encoded
    formats.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703399
Comment 5 Sebastian Dröge (slomo) 2013-08-30 09:33:31 UTC 
*** Bug 707039 has been marked as a duplicate of this bug. ***
Comment 6 Paul HENRYS 2013-08-30 10:08:30 UTC 
When this patch will be pushed on 1.0 branch?
Comment 7 Paul HENRYS 2013-08-30 10:09:31 UTC 
Sorry, did not notice the answer in my duplicate bug :s