Created attachment 246188 [details] [review]
Generalize support for shell's schema overrides

GNOME Shell overrides some settings to use different default values
than standalone mutter. With the introduction of classic mode, things
got a little more complicated, as some of the overrides were reverted
again by extensions - to support either mode, we needed to pick the
right schema for all affected settings.
The shell has now introduced mode-specific overrides, and classic mode
started to use that instead of extensions; this means we will now need
to adapt all settings that *both* normal and classic mode override.
However rather than adjusting the affected settings, the new approach
allows us to generalize the support for schema overrides depending on
the current mode - this should allow us to handle future changes to
overrides in either normal or classic mode automatically.

Good to see this cleaned up.

Does it break old (<3.8) support?

In any case it probbably doesn't matter, I am going to change my policy of keeping master supporting a few different g-s versions and depend on more bleeding edge stuff. I need to use some of the new gtk features for the gsoc g-t-t design update / modernization anyway.

I'll do the branching stuff this weekend.

(In reply to comment #2)
> Good to see this cleaned up.
> 
> Does it break old (<3.8) support?

To be honest, I'd like this in 3.8 if possible - it's more than a cleanup on the shell side, it addresses an annoying classic mode bug. But to answer your question: the patch should work with every shell version since we switched to GSettings (3.2?), with the exception of classic mode in 3.8.

Ok, thanks for the clarification.

If you have tested this against 3.8 then please commit it to master.

Thanks! I'll do so once the shell/extension patches land.

Attachment 246188 [details] pushed as 559b222 - Generalize support for shell's schema overrides

(In reply to comment #4)
> If you have tested this against 3.8 then please commit it to master.

Thanks again!

I should add that by landing bug 701717, some of the options in the last Tweak Tool release stopped working in "classic" mode as provided by gnome-shell-extensions-3.8.3 (just released). So it would be great to get a corresponding release to get this fix out - sorry for that, I'm of course willing to help out if you want me to.

(In reply to comment #6)
> Attachment 246188 [details] pushed as 559b222 - Generalize support for shell's schema
> overrides
> 
> (In reply to comment #4)
> > If you have tested this against 3.8 then please commit it to master.
> 
> Thanks again!
> 
> I should add that by landing bug 701717, some of the options in the last Tweak
> Tool release stopped working in "classic" mode as provided by
> gnome-shell-extensions-3.8.3 (just released). So it would be great to get a
> corresponding release to get this fix out - sorry for that, I'm of course
> willing to help out if you want me to.

Do you want a 3.8.x release from master?

If you need this before Sunday then you may make the release (I am AFK tonight)

Otherwise I will do it tomorrow (Sunday night)

> If you need this before Sunday

We are talking about two switches in Tweak Tool that won't work as expected if you are running the very latest GNOME classic session - so no, it's not so urgent that it cannot wait until next week.

The fix has broken the gnome-tweak-tool under gnome-shell. At least on Arch linux, some entries are missing.

See: https://bugs.archlinux.org/task/36340

This commit has caused this problem: https://git.gnome.org/browse/gnome-tweak-tool/commit/?h=gnome-3-8&id=ad72f1c8701baecdc9838b9bc6ee76748f6fcbd1

Should I report a new bug?

(In reply to comment #10)
> This commit has caused this problem:
> https://git.gnome.org/browse/gnome-tweak-tool/commit/?h=gnome-3-8&id=ad72f1c8701baecdc9838b9bc6ee76748f6fcbd1
> 
> Should I report a new bug?

sure, please copy relevant details from arch bz here.

Just reported as a new bug: #706834