GNOME Bugzilla – Bug 699269
workspace: Only show the close buttons for windows that can close
Last modified: 2014-04-15 13:20:23 UTC
It's not polite to allow people to close windows from the overview that don't have the close button on them. There's also potential from choosing the Quit button if the app doesn't have an app menu, but since that would leave the menu empty, I'm not sure what the design should be.
Created attachment 242856 [details] [review] workspace: Only show the close buttons for windows that can close
Created attachment 242857 [details] [review] window: Add an accessor for whether the window can close The shell will use this to determine whether to show a close button in the overview.
What does "can close" mean? If the window is undecorated (like a fullscreen window) I see no reason why we shouldn't allow the user to close it from the overview. If anything those patches just introduce inconsistency ...
(In reply to comment #3) > What does "can close" mean? If the window is undecorated (like a fullscreen > window) I see no reason why we shouldn't allow the user to close it from the > overview. If anything those patches just introduce inconsistency ... Motif provides a set of hints to hide the close button, and you can test this with a simple GTK+ app: const Gtk = imports.gi.Gtk; Gtk.init(null); let w = new Gtk.Window({ deletable: false }); w.present(); Gtk.main(); As far as I know, those hints are the only thing which controls the "can_close" field in MetaWindow.
(In reply to comment #4) > (In reply to comment #3) > > What does "can close" mean? If the window is undecorated (like a fullscreen > > window) I see no reason why we shouldn't allow the user to close it from the > > overview. If anything those patches just introduce inconsistency ... > > Motif provides a set of hints to hide the close button, and you can test this > with a simple GTK+ app: > > const Gtk = imports.gi.Gtk; > Gtk.init(null); > let w = new Gtk.Window({ deletable: false }); > w.present(); > Gtk.main(); > > As far as I know, those hints are the only thing which controls the "can_close" > field in MetaWindow. OK, which application does that and why?
Well, it was originally filed for gnome-initial-setup, which doesn't have an exit button since it's a special-purpose app, but I think it's more correct, especially when we add support for modal dialogs to the overview.
Review of attachment 242856 [details] [review]: Looks good
Review of attachment 242857 [details] [review]: You've got to change those return types. With that
*** Bug 698609 has been marked as a duplicate of this bug. ***
Comment on attachment 242857 [details] [review] window: Add an accessor for whether the window can close Attachment 242857 [details] pushed as 50b9042 - window: Add an accessor for whether the window can close
Attachment 242856 [details] pushed as e16c16b - workspace: Only show the close buttons for windows that can close
*** Bug 728078 has been marked as a duplicate of this bug. ***