After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698866 - Remember mailman passwords
Remember mailman passwords
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 642884 691271 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-25 16:45 UTC by Bastien Nocera
Modified: 2013-12-18 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remember mailman passwords (9.11 KB, patch)
2013-04-25 16:45 UTC, Bastien Nocera 		none Details | Review
Remember mailman passwords (11.69 KB, patch)
2013-04-25 20:14 UTC, Bastien Nocera 		needs-work Details | Review
P (3.82 KB, patch)
2013-12-10 07:58 UTC, Bastien Nocera 		none Details | Review
Remember mailman passwords (14.43 KB, patch)
2013-12-10 07:58 UTC, Bastien Nocera 		none Details | Review
P (2.14 KB, patch)
2013-12-13 13:43 UTC, Bastien Nocera 		none Details | Review
Remember mailman passwords (15.58 KB, patch)
2013-12-13 13:44 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-04-25 16:45:34 UTC 
.
Comment 1 Bastien Nocera 2013-04-25 16:45:36 UTC 
Created attachment 242440 [details] [review]
Remember mailman passwords

NOTE: Needs cleaning up, but works for me.

There's a magic value ("username-field-not-required"),
the "username-not-required" one can probably go away.
Comment 2 Bastien Nocera 2013-04-25 20:14:44 UTC 
Created attachment 242465 [details] [review]
Remember mailman passwords

UNTESTED.

I've removed the username-*not-required field names, but I
haven't tested further.
Comment 3 Gustavo Noronha (kov) 2013-05-03 18:59:26 UTC 
*** Bug 691271 has been marked as a duplicate of this bug. ***
Comment 4 Gustavo Noronha (kov) 2013-05-03 18:59:34 UTC 
*** Bug 642884 has been marked as a duplicate of this bug. ***
Comment 5 Claudio Saavedra 2013-12-08 17:59:43 UTC 
Review of attachment 242465 [details] [review]:

The patch looks fine but you have to test it first. You can commit afterwards if your computer doesn't blow up.
Comment 6 Bastien Nocera 2013-12-10 07:26:18 UTC 
Comment on attachment 242465 [details] [review]
Remember mailman passwords

Not good enough:
Password for (null) in a form in http://mail.gnome.org/
should be "adminpw" (the name of the field)

URI is too restrictive:
uri: http://mail.gnome.org/

And I get a crasher in the webkit process when re-loading a page that should the password get filled up.
Comment 7 Bastien Nocera 2013-12-10 07:58:10 UTC 
Created attachment 263888 [details] [review]
P

Incremental diff, for review purposes.
Comment 8 Bastien Nocera 2013-12-10 07:58:49 UTC 
Created attachment 263889 [details] [review]
Remember mailman passwords
Comment 9 Bastien Nocera 2013-12-10 08:01:44 UTC 
(In reply to comment #6)
> (From update of attachment 242465 [details] [review])
> Not good enough:
> Password for (null) in a form in http://mail.gnome.org/
> should be "adminpw" (the name of the field)

Conditional was the wrong way around.

> URI is too restrictive:
> uri: http://mail.gnome.org/

Any ideas about how to solve that?

> And I get a crasher in the webkit process when re-loading a page that should
> the password get filled up.

This is fixed.
Comment 10 Bastien Nocera 2013-12-13 13:43:44 UTC 
Created attachment 264144 [details] [review]
P

Another incremental diff.

This one stops the removal of the path from mailman passwords (same host, multiple passwords), and makes the ephy web extension not always ask whether to store passwords if the form doesn't have a user field.
Comment 11 Bastien Nocera 2013-12-13 13:44:24 UTC 
Created attachment 264145 [details] [review]
Remember mailman passwords
Comment 12 Claudio Saavedra 2013-12-18 13:34:08 UTC 
Review of attachment 264145 [details] [review]:

Looks good and I trust you've tested this enough :)
Comment 13 Bastien Nocera 2013-12-18 14:47:55 UTC 
Attachment 264145 [details] pushed as e616f8e - Remember mailman passwords