After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698665 - driver: Disable all WM functions except move
driver: Disable all WM functions except move
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-23 15:19 UTC by Rui Matos
Modified: 2014-09-22 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
driver: Disable all WM functions except move (1.64 KB, patch)
2013-04-23 15:19 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2013-04-23 15:19:15 UTC
The patch to disable minimize made close available. Yeah, this API
isn't great.
Comment 1 Rui Matos 2013-04-23 15:19:17 UTC
Created attachment 242241 [details] [review]
driver: Disable all WM functions except move

Calling gdk_window_set_functions() overrides the 'deletable' property
set on the GtkApplicationWindow instance. So let's just do it in one
place and allow only the WM functions we want.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-04-23 15:22:30 UTC
Review of attachment 242241 [details] [review]:

OK.
Comment 3 Rui Matos 2013-04-23 15:29:53 UTC
Attachment 242241 [details] pushed as a5d01de - driver: Disable all WM functions except move
Comment 4 Mario Sánchez Prada 2014-09-22 14:04:33 UTC
I wonder if there's any specific reason why g-i-s want to allow the user to even move the window around, instead of having it "glued" to the center of the screen.
Comment 5 Rui Matos 2014-09-22 15:22:06 UTC
(In reply to comment #4)
> I wonder if there's any specific reason why g-i-s want to allow the user to
> even move the window around, instead of having it "glued" to the center of the
> screen.

I think that's reasonable. I don't remember if there was a specific reason to allow moving the window. Perhaps just fear that the window would be misplaced by the WM or that it wouldn't fit the screen and the user might want to move it around to see all the content. But yeah, these would all be bugs which should be fixed anyway.

Better to open a new bug and request UI review.
Comment 6 Mario Sánchez Prada 2014-09-22 15:50:33 UTC
Thanks for the feedback. New bug filed and patch attached:
https://bugzilla.gnome.org/show_bug.cgi?id=737126