After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698443 - Folks automagically dependency on zeitgeist
Folks automagically dependency on zeitgeist
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
0.9.x
Other Linux
: Normal minor
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-20 11:33 UTC by Maciej (Matthew) Piechotka
Modified: 2013-04-24 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Remove-autodependency-on-zeitgeist.patch (2.20 KB, patch)
2013-04-20 11:33 UTC, Maciej (Matthew) Piechotka 		committed Details | Review

Description Maciej (Matthew) Piechotka 2013-04-20 11:33:33 UTC 
Created attachment 241983 [details] [review]
0001-Remove-autodependency-on-zeitgeist.patch

Folks automagically depends on zeitgeist library since fixing bug #686506. While it does not cause problems for binary distributions it poses problems for the source-based ones (like Gentoo, Nix etc.) - see http://www.gentoo.org/proj/en/qa/automagic.xml for details (or say http://blog.flameeyes.eu/tag/automagic/ for problems it caused).

The added patch allows the user to add/remove zeitgeist feature while retaining default of automatic enabling/disabling feature.

(See https://bugs.gentoo.org/show_bug.cgi?id=466378 for gentoo bug and https://bugzilla.gnome.org/show_bug.cgi?id=697202 for similar bugs)
Comment 1 Philip Withnall 2013-04-20 19:49:03 UTC 
Review of attachment 241983 [details] [review]:

Looks good. Please commit with the whitespace fixes below.

::: configure.ac
@@ +215,3 @@
+    AS_IF([test x$enable_telepathy_backend = xyes],
+          [PKG_CHECK_MODULES([ZEITGEIST], [zeitgeist-1.0 >= $ZEITGEIST_REQUIRED],
+	                     have_zeitgeist="yes",have_zeitgeist="no")],

Please use spaces rather than tabs.
Comment 2 Maciej (Matthew) Piechotka 2013-04-24 11:33:02 UTC 
Comment on attachment 241983 [details] [review]
0001-Remove-autodependency-on-zeitgeist.patch

Committed with the corrected whitespace