GNOME Bugzilla – Bug 696567
Multifield separator modification
Last modified: 2013-09-28 18:32:38 UTC
Lots of players don't handle multifields very well. Therefore, as a flac user, I don't usually fill multiple fields per field type. For example when it comes to tagging classical music, we could want to tag : "Fauré G. - Orchestre Des Champs Elysées - Philippe Herreweghe" as a single artist tag. Currently, the multifield separator is hardcoded as " - ", leading to several fields instead of one. I wrote this patch to allow user to change the multifield separator in is easytagrc, leaving " - " as a default value.
Created attachment 239789 [details] [review] patch to allow multifield separator value modification
Review of attachment 239789 [details] [review]: EasyTAG already allows the user to disable the tag splitting on a per-field basis, so I do not think that another option is particularly desirable. However, if there is to be another option, it should probably be in the preferences dialogue, alongside the tag splitting options. ::: src/setting.c @@ +334,1 @@ + {"multifield_separator", CV_TYPE_STRING, &MULTIFIELD_SEPARATOR }, Use spaces for indentation, not tabs. @@ +632,3 @@ OPTIONS_WINDOW_WIDTH = 400; + + MULTIFIELD_SEPARATOR = g_strdup(" - "); Again, spaces not tabs for indentation.
It should really be possible to switch it off completely This was discusse a year ago here including patch: https://github.com/stsquad/easytag/issues/19
(In reply to comment #3) > It should really be possible to switch it off completely > > This was discusse a year ago here including patch: > https://github.com/stsquad/easytag/issues/19 That patch was merged, and therefore it is possible to disable the tag splitting completely by disabling it for all fields.
It's not in 2.1.8 which is the latest release?
(In reply to comment #5) > It's not in 2.1.8 which is the latest release? Yes it is, in the preferences dialogue. Go to the "Tag Settings" tab and the bottom frame contains "Tag Splitting" options.
Thank you!
I am hoping that for the next release there will be some Mallard documentation (there is the start of some in help/C in the git version), together with some context-sensitive help buttons, which will make these options more obvious.
Thank you (and the main contributors) again for all the time spent and for this wonderful software. Guillaume
*** Bug 708961 has been marked as a duplicate of this bug. ***
Interesting. IMHO, the default behavior should be the less dangerous for most users, in the GNOME spirit. Splitting tags on such a common pattern as "-" by default, without showing anything in the UI to let the user discover it sounds really not user-friendly. How about changing the default separator to somthing less common, like "|", or disable the "feature" by default? People that use it will find out to enable it, while those who ignore its existence will get trapped all the time.
I have already switched the default to not splitting the tags (see bug 689443), although this was done after 2.1.8 was released. Although I would not have added the feature in the first place, the use of multiple tag fields for Vorbis comments is "permissible, and encouraged" according to the specification: http://xiph.org/vorbis/doc/v-comment.html I would say that any software which ignores the repeated tag fields entriely should be improved to read and show them. There are several improvements in EasyTAG which would make the use of "repeated" tag entries easier, such as showing all tags in a file, some of which are covered by open bugs, such as bug 699476 (although this is for ID3 tags, the same applies to Vorbis comments) and bug 689426.
OK, that's great! It would be good that more software support multiple tag entries indeed, but ATM it does not seem to be the case at all. :-(