GNOME Bugzilla – Bug 696227
gnome-commander fails to build with libgsf 1.14.26
Last modified: 2014-01-08 10:23:07 UTC
libgsf 1.14.26 changed the header layout and is now a one-header include library. gnome-commander fails to build with: [ 794s] gnome-cmd-tags-doc.cc: In function 'void process_metadata(gpointer, gpointer, gpointer)': [ 794s] gnome-cmd-tags-doc.cc:198:52: error: 'gsf_doc_prop_get_val' was not declared in this scope [ 794s] gnome-cmd-tags-doc.cc: In function 'void process_opendoc_infile(GsfInfile*, GnomeCmdFileMetadata*)': [ 794s] gnome-cmd-tags-doc.cc:250:55: error: 'gsf_doc_meta_data_new' was not declared in this scope [ 794s] gnome-cmd-tags-doc.cc:251:27: warning: 'GError* gsf_opendoc_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-opendoc-utils.h:149): Use 'gsf_doc_meta_data_read_from_odf' instead [-Wdeprecated-declarations] [ 794s] gnome-cmd-tags-doc.cc:251:73: warning: 'GError* gsf_opendoc_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-opendoc-utils.h:149): Use 'gsf_doc_meta_data_read_from_odf' instead [-Wdeprecated-declarations] [ 794s] gnome-cmd-tags-doc.cc:254:73: error: 'gsf_doc_meta_data_foreach' was not declared in this scope [ 794s] gnome-cmd-tags-doc.cc: In function 'void process_msole_summary(GsfInput*, GnomeCmdFileMetadata*)': [ 794s] gnome-cmd-tags-doc.cc:264:55: error: 'gsf_doc_meta_data_new' was not declared in this scope [ 794s] gnome-cmd-tags-doc.cc:265:27: warning: 'GError* gsf_msole_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-msole-utils.h:37): Use 'gsf_doc_meta_data_read_from_msole' instead [-Wdeprecated-declarations] [ 794s] gnome-cmd-tags-doc.cc:265:67: warning: 'GError* gsf_msole_metadata_read(GsfInput*, GsfDocMetaData*)' is deprecated (declared at /usr/include/libgsf-1/gsf/gsf-msole-utils.h:37): Use 'gsf_doc_meta_data_read_from_msole' instead [-Wdeprecated-declarations] [ 794s] gnome-cmd-tags-doc.cc:268:73: error: 'gsf_doc_meta_data_foreach' was not declared in this scope [ 794s] gnome-cmd-tags.cc: In member function 'void GnomeCmdFileMetadata::addf(GnomeCmdTag, const gchar*, ...)': [ 794s] gnome-cmd-tags.cc:94:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Created attachment 239410 [details] [review] Detect and support libgsf 1.14.26
Seems that had been addressed in 'some' way in newer versions... Would be more future proof to really only include the main header; just as for glib and other libs.
Thank you! I have seen your bug report just recently. The patch is applied in the current master branch and fixes my previous (not so clean) solution.