After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695967 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review 772263
 
 
Reported: 2013-03-16 14:24 UTC by TLE
Modified: 2016-10-03 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use Unicode in translatable strings (60.86 KB, patch)
2016-09-30 18:31 UTC, Piotr Drąg 		none Details | Review
Unmark empty strings and numbers from translation (26.50 KB, patch)
2016-09-30 18:51 UTC, Piotr Drąg 		none Details | Review
Remove double spaces from translatable strings (17.48 KB, patch)
2016-09-30 18:51 UTC, Piotr Drąg 		none Details | Review

Description TLE 2013-03-16 14:24:47 UTC 
Hallo NetworkManager applet devs

I was wondering what the rationale is behind changing e.g. all the ellipsis characters back from unicode to ascii. We are making the reverse movement for a lot of other modules for GNOME, so why exactly are you going back?

Regards Kenneth
Comment 1 Dan Winship 2014-01-02 17:50:44 UTC 
This probably had something to do with RHEL6... either we intentionally changed everything back to ascii ellipses to make it easier to backport changes to RHEL6, or else we accidentally did it while forward-porting a change that had been originally done in RHEL6.

Anyway, if GNOME as a whole is moving to unicode ellipses then we're happy to take patches to fix it. (Ideally the patches should change both the .c files and the .po files so that we don't break large numbers of translations.)
Comment 2 Pavel Simerda 2014-11-23 18:54:28 UTC 
Are any patches coming for this?
Comment 3 Piotr Drąg 2016-09-30 18:31:21 UTC 
Created attachment 336690 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 4 Piotr Drąg 2016-09-30 18:51:25 UTC 
Created attachment 336693 [details] [review]
Unmark empty strings and numbers from translation

While I'm at it, here is a couple of other improvement patches to translatable strings.
Comment 5 Piotr Drąg 2016-09-30 18:51:41 UTC 
Created attachment 336694 [details] [review]
Remove double spaces from translatable strings
Comment 6 Thomas Haller 2016-10-03 16:31:10 UTC 
patches lgtm
Comment 7 Piotr Drąg 2016-10-03 16:52:16 UTC 
So can I push them to git now?
Comment 8 Beniamino Galvani 2016-10-03 18:45:06 UTC 
LGTM
Comment 9 Thomas Haller 2016-10-03 18:55:25 UTC 
merged to master: https://git.gnome.org/browse/network-manager-applet/commit/?id=05c64b282ffc7b9a205c509dd3c7b747cacff62f

Thanks Piotr for the patches!
Comment 10 Piotr Drąg 2016-10-03 19:11:22 UTC 
Thank you for such a quick reaction.

Should I submit similar patches for each VPN plug-in, or maybe I could just commit the changes directly?
Comment 11 Thomas Haller 2016-10-03 19:20:57 UTC 
(In reply to Piotr Drąg from comment #10)
> Thank you for such a quick reaction.
> 
> Should I submit similar patches for each VPN plug-in, or maybe I could just
> commit the changes directly?

Please go ahead and just commit them directly! Thanks

(you probably noticed that there are not "nm-1-2" nor "nm-1-4" branches for the plugins. There is no need to created them, fix it only on master. It seems not necessary to fix it for the old-stable branches "nm-1-2" or older).