After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692680 - Clean up our code that deals with monitor geometry and the work area
Clean up our code that deals with monitor geometry and the work area
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 692679
Blocks:
 
 
Reported: 2013-01-28 06:57 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-07 03:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspace: Use mutter's work area calcuating rather than doing it manually (1.48 KB, patch)
2013-01-28 06:57 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
layout: Use the mutter functions for doing monitor math (2.83 KB, patch)
2013-01-28 06:57 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Switch all external uses of Main.panel.actor.height to the work area (6.73 KB, patch)
2013-01-28 06:57 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
Switch all external uses of Main.panel.actor.height to the work area (6.73 KB, patch)
2013-02-06 22:18 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-28 06:57:34 UTC 
Lots of places use Main.panel.actor.height directly, which sort of
bugs me out for various reasons. Let's replace these with mutter's own
work area calculations.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-28 06:57:37 UTC 
Created attachment 234592 [details] [review]
workspace: Use mutter's work area calcuating rather than doing it manually
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-28 06:57:40 UTC 
Created attachment 234593 [details] [review]
layout: Use the mutter functions for doing monitor math
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-28 06:57:43 UTC 
Created attachment 234594 [details] [review]
Switch all external uses of Main.panel.actor.height to the work area
Comment 4 Giovanni Campagna 2013-01-28 08:44:14 UTC 
Review of attachment 234592 [details] [review]:

Yes, definitely.
Comment 5 Giovanni Campagna 2013-01-28 08:50:24 UTC 
Review of attachment 234594 [details] [review]:

::: js/ui/overview.js
@@ +380,3 @@
         this._overview.set_size(primary.width, primary.height);
 
+        this._coverPane.set_position(0, workArea.width);

This doesn't look right...
And neither does primary.width below.
Comment 6 drago01 2013-02-03 13:21:00 UTC 
Review of attachment 234593 [details] [review]:

Makes sense.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-02-06 22:18:15 UTC 
Created attachment 235342 [details] [review]
Switch all external uses of Main.panel.actor.height to the work area
Comment 8 Giovanni Campagna 2013-02-06 23:00:57 UTC 
Review of attachment 235342 [details] [review]:

Ok
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-02-07 03:36:21 UTC 
Attachment 234592 [details] pushed as 0335f27 - workspace: Use mutter's work area calcuating rather than doing it manually
Attachment 234593 [details] pushed as 60985b3 - layout: Use the mutter functions for doing monitor math
Attachment 235342 [details] pushed as 12ac2e5 - Switch all external uses of Main.panel.actor.height to the work area