After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692231 - Footers don't go all the way down if screen is too high
Footers don't go all the way down if screen is too high
Status: RESOLVED OBSOLETE
Product: website
Classification: Infrastructure
Component: mail.gnome.org
current
Other Linux
: Normal normal
: ---
Assigned To: GNOME Web maintainers
GNOME Web maintainers
: 700482 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-01-21 19:28 UTC by Andreas Nilsson
Modified: 2018-09-24 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Attachment contains the full code. (87.11 KB, application/x-gzip)
2013-11-06 11:05 UTC, Monam Agarwal
  Details
This is the patch for above edited code. (173.30 KB, patch)
2013-11-06 17:33 UTC, Monam Agarwal
none Details | Review
Solved the bug footers don't go all the way down when screen too high (3.68 KB, patch)
2013-11-06 20:23 UTC, Monam Agarwal
none Details | Review
Sticky footer bug 692231 (1.43 KB, patch)
2015-01-22 13:44 UTC, Richard Denton
none Details | Review

Description Andreas Nilsson 2013-01-21 19:28:40 UTC
Need to find a strategy to make it go all the way to the bottom.
Comment 1 Andreas Nilsson 2013-04-10 13:10:27 UTC
As for now, it depends on the amount of content in the page.
There seems to be some ways to fix this, but it needs to play well together with the 960 framework.

A google search for "sticky footer" reveals some alternatives.
Comment 2 Monam Agarwal 2013-11-06 11:05:41 UTC
Created attachment 259062 [details]
Attachment contains the full code.

This attachment contains the theme with the bug fixed.
Comment 3 Monam Agarwal 2013-11-06 17:33:39 UTC
Created attachment 259124 [details] [review]
This is the patch for above edited code.
Comment 4 Monam Agarwal 2013-11-06 20:23:50 UTC
Created attachment 259136 [details] [review]
Solved the bug footers don't go all the way down when screen too high
Comment 5 Andreas Nilsson 2013-11-07 10:13:08 UTC
Monam: Can you make sure it's possible to apply the patch from the top level directory? Right now it looks like it needs to be applied inside the theme directory, instead of the top level directory.
Comment 6 Andreas Nilsson 2013-11-07 11:39:59 UTC
Sorry, nevermind, ignore the above comment, I mixed it up with something else.
Comment 7 Andrea Veri 2013-11-07 16:37:26 UTC
@Monam: seems the patch isn't working as expected, the footer is still not being sticky and the homepage was broken. How did you test the patch? do you have a local mailman installation to test this?
Comment 8 Monam Agarwal 2013-11-08 07:10:54 UTC
I tested the attachment which i posted earlier on various browsers like firefox, Chrome and IE8. It worked fine on all these platforms. However i have no mechanism to test the patch
Comment 9 Tobias Mueller 2014-11-26 21:49:04 UTC
*** Bug 700482 has been marked as a duplicate of this bug. ***
Comment 10 Richard Denton 2015-01-22 13:44:48 UTC
Created attachment 295169 [details] [review]
Sticky footer bug 692231

A javascript method of ensuring that the footer (and its artwork) always
sits at the bottom of the screen
Comment 11 Tom Tryfonidis 2017-01-20 12:27:47 UTC
Another solution using CSS flex (also used on gnome.org). 

Compatibility: Modern browsers have flex support, see also http://caniuse.com/#search=flex

CSS code:

/* Sticky Footer */
.gnome-body {
  display: flex;
  flex-direction: column;
  min-height: 100vh;
}
.gnome-content{
  flex: 1;
}

HTML markup:

<html>
<body class="gnome-body ">
 <div class="gnome-content">
   Page content
 </div>

 <!-- Fotoer remains to the bottom -->
 <footer>
  Content
 </footer>

</body>
</html>
Comment 12 GNOME Infrastructure Team 2018-09-24 10:29:02 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/Infrastructure/Websites/issues/105.