After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690084 - gmarkup: Make GMarkupParseContext a boxed type
gmarkup: Make GMarkupParseContext a boxed type
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-12-12 09:57 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-01 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gmarkup: Make GMarkupParseContext a boxed type (5.04 KB, patch)
2012-12-12 09:57 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
gmarkup: Make GMarkupParseContext a boxed type (5.62 KB, patch)
2012-12-14 07:14 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-12 09:57:09 UTC 
I had this in my local tree, but I forget why.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-12 09:57:11 UTC 
Created attachment 231327 [details] [review]
gmarkup: Make GMarkupParseContext a boxed type

At the same time, add a refcount and public ref/unref methods.
This makes it usable from introspectable.
Comment 2 Colin Walters 2012-12-12 13:39:07 UTC 
Is it really usable though?  I don't think gjs at least has support for setting up the callbacks in the structure.  Where were you using this?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-12 20:34:37 UTC 
In combination with #679299.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-12 20:34:47 UTC 
grah, bug #679299
Comment 5 Colin Walters 2012-12-12 22:52:56 UTC 
Review of attachment 231327 [details] [review]:

Also need to patch gobject/gobject.symbols.

::: glib/gmarkup.c
@@ +119,3 @@
   const GMarkupParser *parser;
 
+  gint ref_count;

volatile, per g_atomic_int API

@@ +279,3 @@
+ * Returns: the same @context
+ *
+ * Since: 2.34

2.36 now

@@ +299,3 @@
+ * drops to 0, it is freed.
+ *
+ * Since: 2.34

2.36 now

@@ +1040,3 @@
  * g_markup_parse_context_parse:
  * @context: a #GMarkupParseContext
+ * @text: (array length=text_len): chunk of text to parse

Per bug 688731, I don't think this should have an annotation right now.  It's *not* an array.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-12-14 07:14:08 UTC 
Created attachment 231541 [details] [review]
gmarkup: Make GMarkupParseContext a boxed type

At the same time, add a refcount and public ref/unref methods.
This makes it usable from introspectable.
Comment 7 Matthias Clasen 2012-12-19 19:24:03 UTC 
Review of attachment 231541 [details] [review]:

::: glib/gmarkup.c
@@ +279,3 @@
+ * Returns: the same @context
+ *
+ * Since: 2.34

2.36

@@ +299,3 @@
+ * drops to 0, it is freed.
+ *
+ * Since: 2.34

2.36

::: glib/gmarkup.h
@@ +184,3 @@
                                                    GDestroyNotify       user_data_dnotify);
+GMarkupParseContext *g_markup_parse_context_ref   (GMarkupParseContext *context);
+void                 g_markup_parse_context_unref (GMarkupParseContext *context);

G_AVAILABLE_IN_2_36
Comment 8 Matthias Clasen 2013-01-01 16:03:02 UTC 
Fixed up, and pushed.

Attachment 231541 [details] pushed as 5e62827 - gmarkup: Make GMarkupParseContext a boxed type