After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689261 - Differentiate touch rings from touch strips
Differentiate touch rings from touch strips
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Olivier Fourdan
gnome-settings-daemon-maint
Depends on:
Blocks: 689264
 
 
Reported: 2012-11-29 10:30 UTC by Olivier Fourdan
Modified: 2012-12-20 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (7.22 KB, patch)
2012-11-29 11:15 UTC, Olivier Fourdan 		accepted-commit_now Details | Review
Updated patch after review (7.70 KB, patch)
2012-12-19 14:34 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2012-11-29 10:30:03 UTC 
Using "up" and "down" on a ring is ambiguous, better use "CW" or "CCW" to indicate the circular motion on touch rings.

Differentiating rings from strips is therefore required to use the appropriate terminology depending on the type of elevator.
Comment 1 Olivier Fourdan 2012-11-29 11:15:59 UTC 
Created attachment 230172 [details] [review]
Proposed patch
Comment 2 Bastien Nocera 2012-12-14 14:29:43 UTC 
Review of attachment 230172 [details] [review]:

Looks good otherwise.

::: plugins/wacom/gsd-wacom-manager.c
@@ +1182,3 @@
 		 wbutton->id,
+		 (wbutton->type == WACOM_TABLET_BUTTON_TYPE_RING) ? (dir == GTK_DIR_UP ? " 'CCW'" : " 'CW'") :
+		 (wbutton->type == WACOM_TABLET_BUTTON_TYPE_STRIP) ? (dir == GTK_DIR_UP ? " 'up'" : " 'down'") : "",

You'll need to split that up, it's getting unreadable.
Comment 3 Olivier Fourdan 2012-12-19 14:34:13 UTC 
Created attachment 231884 [details] [review]
Updated patch after review

(In reply to comment #2)
> Review of attachment 230172 [details] [review]:
> [...]
> You'll need to split that up, it's getting unreadable.

Done.
Comment 4 Bastien Nocera 2012-12-19 14:41:40 UTC 
Review of attachment 231884 [details] [review]:

Looks good.
Comment 5 Olivier Fourdan 2012-12-20 09:18:35 UTC 
Comment on attachment 231884 [details] [review]
Updated patch after review

Pushed in git master