GNOME Bugzilla – Bug 689171
Note text can appear beneath the last updated label
Last modified: 2018-05-04 12:05:54 UTC
Created attachment 230013 [details] screenshot See the attached screenshot - the text appears superimposed on top of the last updated label. The mockups suggest that the last updated label should appear at the bottom of the note as a footer: https://raw.github.com/gnome-design-team/gnome-mockups/master/notes/notes-single.png (Notice that the page lines stop above the last updated label.)
Sorry i just saw i did not feed back about this one. "Assigned" since it's obviously a right bug, but i did not even decided which way to go - eg "footer" as in html, meaning some re-vamp there, or stick with current option of some widget on top, meaning working on the layout.
*** Bug 708305 has been marked as a duplicate of this bug. ***
from #708305 jimmac: Similar behavior has been solved on the web by having the footer float by default, but if the scrollable is taller than the window size, the footer is not floating but static.
Created attachment 258159 [details] Some dirty widget we do not want One way would be to simply pack a widget, with almost no code. The issue is that scrollbar won't be fine. Just to be sure i am not the only one dismissing this solution.
Now I'm using a GtkWidget for this. To be honest this is slightly worse for now.
The format widget (appears when select some text) can be hided by the last updated label too.
(In reply to comment #6) > The format widget (appears when select some text) can be hided by the last > updated label too. Yes the last updated is currently a GtkLabel* https://git.gnome.org/browse/bijiben/tree/src/bjb-note-view.c#n171 The widget to cut/copy/paste is a popover. This part is fine. Back to the GtkLabel. The more natural would be to use html power there. We can rely on some java script to add a footer to actual note content. This would imply to remove the widget, the WebkitWebView would include this footer.
Could be possible to at least move it to the right, so it is less obvious. Because once you are at the bottom, it's difficult to write anything there, with that label on top. Although, people who use RTL... how does that work?
(In reply to comment #8) > Could be possible to at least move it to the right, so it is less obvious. > Because once you are at the bottom, it's difficult to write anything there, > with that label on top. I confess this should have been done long time ago. Better late than never : commit 0fbd7f5cd8f2cbc228205d6772b9627d21c5245d > Although, people who use RTL... how does that work? In theory we should make it opposite for RTL, but unfortunately a bug is currently opened about these not working.
Moving the label to the right still means that the "last updated" text can be displayed over the note text, so it doesn't actually fix the bug. Wouldn't showing "last updated" as a footer be better?
(In reply to comment #10) > ... Wouldn't > showing "last updated" as a footer be better? Alternatively, if it is really so hard to put the last updated text in the note itself, it could be shown in the header bar, as a sub-heading.
I discussed this bug with Cosimo yesterday, and he made the good point that you probably don't need to see the last updated information all the time when viewing a note - this information is actually more important in the notes grid/list. Therefore, a good approach would be to move the last updated information to the header bar menu, as an insensitive label. Sound good?!
I'm seeing this behavior on 3.14.2 (Debian "jessie/testing"). The 'Last updated' text in the notes view (not the notes index or listing view) interferes with reading of notes content itself, and at first seemed like some kind of z-ordering issue to me. I don't see the value of presenting this info on the note itself.
(In reply to Allan Day from comment #12) ... > Therefore, a good approach would be to move the last updated information to > the header bar menu, as an insensitive label. Sound good?! I discussed this proposal with Pierre yesterday, and he is happy with it.
Created attachment 316733 [details] [review] move "last updated" to note menu (In reply to Allan Day from comment #14) > (In reply to Allan Day from comment #12) > ... > > Therefore, a good approach would be to move the last updated information to > > the header bar menu, as an insensitive label. Sound good?! > > I discussed this proposal with Pierre yesterday, and he is happy with it. Patch moving "Last updated" to an insensitive menu item at the bottom of the note menu. Includes translation updates, as "<b>" tags are removed from the string.
The text doesn't change when you edit the note, but I notice that's a problem before my patch, too -- #759003 This patch should also resolve #726067 (if it's still outstanding)
(In reply to Carl van Tonder from comment #15) > Created attachment 316733 [details] [review] [review] > move "last updated" to note menu can you split code change from .po translations change?
Created attachment 316891 [details] [review] Move "Last updated" to menu
Created attachment 316892 [details] translation updates for "Last updated" change
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-notes/issues/3.