After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687690 - Support X-TELEPATHY-PASSWORD for GOA accounts
Support X-TELEPATHY-PASSWORD for GOA accounts
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Auth client
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 687578
Blocks:
 
 
Reported: 2012-11-05 21:34 UTC by Debarshi Ray
Modified: 2012-11-09 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
auth-client: Support X-TELEPATHY-PASSWORD for GOA accounts (3.87 KB, patch)
2012-11-05 21:50 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-11-05 21:34:27 UTC 
GOA providers can now offer a PasswordBased interface in addition to OAuth / OAuth ones. See bug 687578 for the background, some of which would be familiar from Empathy's perspective.

We can take advantage of this in GNOME 3.6 to solve the mess caused by GMail OAuth vs. GTalk OAuth2, where the user has to enter the password again for GTalk accounts. [1]

Apart from that this would be useful to support other password based accounts coming from GOA in the future.

[1] GMail has since move to OAuth2 and therefore this has been solved for GNOME 3.8 (see bug 652546)
Comment 1 Debarshi Ray 2012-11-05 21:50:25 UTC 
Created attachment 228190 [details] [review]
auth-client: Support X-TELEPATHY-PASSWORD for GOA accounts
Comment 2 Xavier Claessens 2012-11-06 14:14:48 UTC 
Looks good to me.
Comment 3 Debarshi Ray 2012-11-06 15:02:03 UTC 
Thinking about this, we still won't have an answer for those using 2-factor authentication with GNOME 3.6. The only solution for them is to use >= 3.7.x

But atleast it would be an improvement for the others.
Comment 4 Debarshi Ray 2012-11-09 12:34:00 UTC 
Pushed to master and gnome-3-6.This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.