Created attachment 227294 [details] [review]
Make selection toolbar look like gnome-documents

This uses the standard Adwaita themeing, plus it copies the size
and positioning of the toolbar from documents. It also uses
the same left/right group split.

Created attachment 227295 [details] [review]
Remove unused css

We don't need to have custom CSS for the selection bar anymore.

Created attachment 227296 [details] [review]
Add select All/None/Running menu to selection toolbar

This is similar to gnome-documents, although we added
the "running" state as proposed by jimmac.

Created attachment 227297 [details] [review]
Add parenthesis around "Click on items to select them"

This is what gnome-documents does in the selection toolbar.

These patches depend on the ones in bug #686777.

Also, this does not really change the order of the buttons wrt the 
split in the middle. But I've been discussing this with the design folks, and
I don't think the current use is *quite* right. It should be more like
the things on the left are actions on the items, and the right is more like properties (although they were a little fuzzy on this).

I think the right split for us is probably 
favourite, save, delete on the left
and properties on the right

Although we don't have properties yet.

Oh, and another bug is that we should show the search button also in selection mode, like documents.

Created attachment 227336 [details] [review]
searchbar: Clear search when dismissed

When we're not showing the search field we should
always show all entries.

Created attachment 227337 [details] [review]
Add search button to selection mode toolbar too

Also, we should add hover text to the overlay toolbar items.

Review of attachment 227294 [details] [review]:

Not any expert on theming so if you have tested it and it works/looks good, do commit! + I don't see any obvious problems in the patch.

Review of attachment 227295 [details] [review]:

Always nice to see lines getting removed. :) Same thing for this one, if it works/looks good..

Review of attachment 227294 [details] [review]:

Not any expert on theming so if you have tested it and it works/looks good, do commit! + I don't see any obvious problems in the patch.

Review of attachment 227296 [details] [review]:

Looks good.

::: src/collection-view.vala
@@ +2,3 @@
 using Clutter;
 
+public enum Boxes.Selection {

I'd recommend: Selection -> SelectionCriteria

Review of attachment 227297 [details] [review]:

ACK

Review of attachment 227336 [details] [review]:

by 'entries' you meant 'item' in the commit log? Good otherwise but log detail got me confused.

Review of attachment 227337 [details] [review]:

ACK anyways.

::: src/topbar.vala
@@ +18,3 @@
     private Gtk.Spinner spinner;
     private Gtk.ToggleButton search_btn;
+    private Gtk.ToggleButton search2_btn;

search2_btn -> search_btn2 ?

Attachment 227294 [details] pushed as 15ede51 - Make selection toolbar look like gnome-documents
Attachment 227295 [details] pushed as 9cdb870 - Remove unused css
Attachment 227296 [details] pushed as 7b0c636 - Add select All/None/Running menu to selection toolbar
Attachment 227297 [details] pushed as 821956d - Add parenthesis around "Click on items to select them"
Attachment 227336 [details] pushed as 6f320f7 - searchbar: Clear search when dismissed
Attachment 227337 [details] pushed as 7013c3a - Add search button to selection mode toolbar too

Review of attachment 227296 [details] [review]:

::: src/collection-view.vala
@@ +2,3 @@
 using Clutter;
 
+public enum Boxes.Selection {

Missed this one, and i agree. Will change.

Created attachment 227519 [details] [review]
Rename Selectiion enum to SelectionCriteria

Comment on attachment 227519 [details] [review]
Rename Selectiion enum to SelectionCriteria

Attachment 227519 [details] pushed as 587b309 - Rename Selectiion enum to SelectionCriteria

Still missing:
* hover text, or switch to text instead of icons if the designers agree
* decide what is the right grouping

Bug 686941 seems to say we should use text for the buttons.

I think the grouping is right as is, so making this a dup of 686941

*** This bug has been marked as a duplicate of bug 686941 ***