After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686756 - Super+F10 opens the app menu but doesn't close it
Super+F10 opens the app menu but doesn't close it
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-24 05:07 UTC by Jeremy Bicha
Modified: 2013-04-26 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
panel: Change openAppMenu() to a toggle action (2.67 KB, patch)
2013-04-26 15:13 UTC, Florian Müllner 		committed Details | Review
PopupMenuManager: Close active menu when another one opens (1.08 KB, patch)
2013-04-26 15:14 UTC, Florian Müllner 		accepted-commit_now Details | Review
PopupMenuManager: Close active menu when another one opens (1.68 KB, patch)
2013-04-26 15:53 UTC, Florian Müllner 		committed Details | Review

Description Jeremy Bicha 2012-10-24 05:07:12 UTC 
Pressing Super+F10 opens the app menu, but pressing Super+F10 a second time doesn't close it.
Comment 1 Florian Müllner 2012-10-24 07:32:57 UTC 
Neither do F10 or Shift+F10 in GTK+ applications :-)
Comment 2 Jeremy Bicha 2012-10-24 14:19:29 UTC 
F10 did seem to work that way (to open and to close) in gnome-terminal when I tried yesterday and F10 in general is working that way for me now.

I think combo shortcuts are a bit trickier but I don't think it's impossible.
Comment 3 Giovanni Campagna 2012-10-24 19:54:09 UTC 
Generally, this has the same issues as bug 682229 (which in turn depends on a patchset from bug 613543).
Once that's fixed, it's easy to change Panel.openAppMenu() to toggle it instead.
Comment 4 gatlin 2013-01-28 01:54:21 UTC 
This may be fixed with bug 688202.
It is unfortunate that that fix missed 3.6.2. I only use stable versions.
Comment 5 Florian Müllner 2013-04-26 15:13:50 UTC 
Created attachment 242582 [details] [review]
panel: Change openAppMenu() to a toggle action

It makes sense to allow closing the app menu with the same shortcut
that is used to open it, so make it a toggle action and allow it
TOPBAR_POPUP mode.
Comment 6 Florian Müllner 2013-04-26 15:14:35 UTC 
Created attachment 242583 [details] [review]
PopupMenuManager: Close active menu when another one opens

We already do this when navigating between menus via mouse or
keynav, but miss cases where a menu is opened by other means,
for instance via a keyboard shortcut.

Not a big fan of this approach, but couldn't come up with anything better off-hand ...
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-04-26 15:20:53 UTC 
Review of attachment 242583 [details] [review]:

You should probably remove this._changeMenu in this case, too. I actually like this.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-04-26 15:22:28 UTC 
Review of attachment 242582 [details] [review]:

OK.
Comment 9 Florian Müllner 2013-04-26 15:53:36 UTC 
Created attachment 242590 [details] [review]
PopupMenuManager: Close active menu when another one opens

(In reply to comment #7)
> You should probably remove this._changeMenu in this case, too. I actually like
> this.

Not sure I get what you are trying to say - I assume you mean removing the close() call from _changeMenu() (as it's not handled by open-state-changed)?
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-04-26 15:55:31 UTC 
Review of attachment 242590 [details] [review]:

No, I mean removing _changeMenu entirely, as it's a one-liner at this point, but this is fine too.
Comment 11 Florian Müllner 2013-04-26 16:03:30 UTC 
Attachment 242582 [details] pushed as 60cb1ad - panel: Change openAppMenu() to a toggle action
Attachment 242590 [details] pushed as c84dc62 - PopupMenuManager: Close active menu when another one opens