After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686458 - slightly increase poll duration in test_timed_wait
slightly increase poll duration in test_timed_wait
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.34.x
Other OpenBSD
: Normal trivial
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-10-19 12:06 UTC by Antoine Jacoutot
Modified: 2012-10-19 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
increase poll duration in test_timed_wait (1.06 KB, patch)
2012-10-19 12:06 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2012-10-19 12:06:17 UTC 
Created attachment 226817 [details] [review]
increase poll duration in test_timed_wait

Hi.

I am regularly running the GLib regression tests for fix that needs be in OpenBSD (or add support for missing features).
I've been annoyed that from time to time, the timed_wait test will fail with an error similar to:

GLib-GIO:ERROR:socket.c:620:test_timed_wait:
    assertion failed (poll_duration < 110000): (110057 < 110000)

This patch increases the poll duration in the same way https://bugzilla.gnome.org/show_bug.cgi?id=678881 did, but in the other direction.

Would that be alright to push?
Comment 1 Dan Winship 2012-10-19 12:23:34 UTC 
Comment on attachment 226817 [details] [review]
increase poll duration in test_timed_wait

sure... i wish there was a more reliable way to deal with these sorts of tests...
Comment 2 Antoine Jacoutot 2012-10-19 12:44:52 UTC 
Pushed, thanks Dan.