After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685583 - Touchpad disable button should not be shown when there is only a touchpad
Touchpad disable button should not be shown when there is only a touchpad
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Mouse
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 687511 689126 693730 (view as bug list)
Depends on: 685941
Blocks:
 
 
Reported: 2012-10-05 20:27 UTC by Justin
Modified: 2013-02-13 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mouse: Don't show touchpad disable button when there isn't mouse (1.18 KB, patch)
2012-10-11 08:38 UTC, Ondrej Holy 		committed Details | Review

Description Justin 2012-10-05 20:27:33 UTC 
The new touchpad module has a button to disable the touchpad. This switch should not be shown when there is only a touchpad but no mouse available. Accidentally disabling the touchpad will cause confusion to new users.

There is already a setting for disable touchpad while editing and no other use cases (that I am aware of) warrant such a button (when there is only one touchpad and no mouse).
Comment 1 Bastien Nocera 2012-10-09 09:41:23 UTC 
At the same time, we also need to make sure that the touchpad gets re-enabled when the last mouse gets unplugged, and we need the toggle touchpad button not to work when there's only a touchpad present.
Comment 2 Ondrej Holy 2012-10-11 08:38:17 UTC 
Created attachment 226234 [details] [review]
mouse: Don't show touchpad disable button when there isn't mouse
Comment 3 Bastien Nocera 2012-10-11 08:50:18 UTC 
Review of attachment 226234 [details] [review]:

This needs to wait until the gnome-settings-daemon parts are fixed though (re-enabling the touchpad if it's the last pointer device present).
Comment 4 Bastien Nocera 2012-10-11 15:17:49 UTC 
Attachment 226234 [details] pushed as 5b2818c - mouse: Don't show touchpad disable button when there isn't mouse
Comment 5 Bastien Nocera 2012-11-05 16:05:09 UTC 
*** Bug 687511 has been marked as a duplicate of this bug. ***
Comment 6 Bastien Nocera 2012-11-27 06:48:43 UTC 
*** Bug 689126 has been marked as a duplicate of this bug. ***
Comment 7 Matthew Garrett 2012-11-27 06:59:28 UTC 
This won't work - if there's a PS/2 trackpad on the system, it'll also be reported as a mouse.
Comment 8 Bastien Nocera 2012-11-27 07:03:44 UTC 
(In reply to comment #7)
> This won't work - if there's a PS/2 trackpad on the system, it'll also be
> reported as a mouse.

As long as it's marked as a trackpad in udev, it'll be a trackpad in GNOME, and the above code will kick in.

You'll need to get the right udev rules for your platform to tag the device as a trackpad.
Comment 9 Matthew Garrett 2012-11-27 07:12:57 UTC 
I /think/ the only case where this will work as you want it to is on Thinkpads. On anything else, you'll have a single device and won't be able to tell whether it's a trackpad or a trackpad plus trackpoint.
Comment 10 Bastien Nocera 2013-02-13 17:18:15 UTC 
*** Bug 693730 has been marked as a duplicate of this bug. ***