GNOME Bugzilla – Bug 684935
region: build IBus setup app filename only from the engine prefix
Last modified: 2012-10-02 14:54:42 UTC
There are 84 m17n engines in the whitelist and they all use ibus-setup-m17n. To reduce the number of .desktop files, this patch uses the prefix before the first ":" to construct the .desktop filename and set IBUS_ENGINE_NAME envvar to let the setup app know the actual engine ID.
Created attachment 225248 [details] [review] region: build IBus setup app filename only from the engine prefix
Review of attachment 225248 [details] [review]: Yep, this looks fine, thanks. I don't see a setup tool for m17n though, not in the fedora packages nor upstream. Are you going to provide one?
(In reply to comment #2) > I don't see a setup tool for m17n though, not in the fedora packages nor > upstream. Are you going to provide one? Yes, https://codereview.appspot.com/6572062/
What needs to be configured in all m17n engines ? I think we ideally want to keep per-engine configurability to a minimum.
(In reply to comment #4) > What needs to be configured in all m17n engines ? The common settings in all m17n engines are: - pre-edit appearance some language users want pre-edit to be decorated but others don't - look up table orientation In addition, there are pre-engine configuration in m17n engines theirselves. You could check it with: $ grep -A5 "^(variable" /usr/share/m17n/*.mim | less For example, Thai engines only have "acceptance-level" setting of input words (which is needed). > I think we ideally want to keep per-engine configurability to a minimum. I know and I think the current options are well designed to be minimum, for m17n engines.
Attachment 225248 [details] pushed as fb6c89f - region: build IBus setup app filename only from the engine prefix