Created attachment 225075 [details] [review]
gdm: Provide an accessible name for powerMenu

Trivial patch, but requires a string freeze break ...

Tested, and works.

We'll ask for a freeze break for the entire patch set (including gnome-session, gdm and gnome-shell) in a bit.

Providing one r-t approval here, in case this speeds up the process.

(In reply to comment #3)
> Providing one r-t approval here, in case this speeds up the process.

In case II, providing another r-t approval here.

Review of attachment 225075 [details] [review]:

Looks good.

Gabor Kelemen wrote on release-team@:

If I did not missed something, only this one needs i18n approval.
So here you go, 1/2 from i18n.

Would it be possible to add a translator comment too? I feel that "Power" here is just too generic. Something like:
Translators: accessible description of the Power menu on the Login screen

(thread is here: https://mail.gnome.org/archives/release-team/2012-September/msg00289.html )

and Gil Forcada wrote:

With a nice translating comment I wouldn't mind to give the 2/2
approval, so once you get a nice one... go ahead!

So we've got 2 release team and two i18n team approvals for this bug.

(In reply to comment #6)
> Would it be possible to add a translator comment too? I feel that "Power" here
> is just too generic. Something like:
> Translators: accessible description of the Power menu on the Login screen

Not sure to be honest - is "Power" really more generic than "Battery" or "Volume" (e.g. other accessible names in the top bar that don't have a translator comment (all items actually))?

Attachment 225075 [details] pushed as 9f476a1 - gdm: Provide an accessible name for powerMenu

... anyway, I don't feel like arguing at 2am - pushing with the suggested translator comment.

well that's probably an argument for giving a translator comment for those, too.

I think the point of the comment is so translators know what "form" of the word to use when a language would use a different word for Power in a menu item than Power in other contexts.  I couldn't give you a specific example of a language where that ambiguity exists (because I only know English), but I generally don't refuse a translator when they ask for a translator comment.

Anyway, something to bring up on the thread I guess.

(In reply to comment #11)
> [...] but I generally don't refuse a translator when they ask 
> for a translator comment.

Neither did I :-)

(I'm assuming the patch got reopened by accident, closing again)

Gah, s/patch/bug/ of course!