Created attachment 224611 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar

Created attachment 224612 [details]
test program

Created attachment 224613 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar

Fixed silliness

Created attachment 224614 [details] [review]
level-bar: add support for RTL locales

Both very reasonable ideas.
The first patch is missing Since: 3.8 and GDK_AVAILABLE_IN_3_8

Created attachment 224735 [details] [review]
Add gdk version macros for 3.8

Created attachment 224736 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar

Review of attachment 224736 [details] [review]:

Looks fine overall - the new symbols should also be added to docs/reference/gtk/gtk3-sections.txt

::: gtk/gtklevelbar.c
@@ +307,3 @@
 gtk_level_bar_draw_fill_continuous (GtkLevelBar           *self,
                                     cairo_t               *cr,
+                                    gboolean               inverted,

No need to pass inverted down to all methods, since it's available in self->priv.

@@ +1277,3 @@
+ * @self: a #GtkLevelBar
+ *
+ * Gets the value set by gtk_level_bar_set_inverted().

"Returns the value of the inverted property" to be consistent with the other methods.

@@ +1294,3 @@
+ * gtk_level_bar_set_inverted:
+ * @self: a #GtkLevelBar
+gboolean

progress bar -> level bar

@@ +1296,3 @@
+ * @inverted: %TRUE to invert the progress bar
+ *
+gtk_level_bar_get_inverted (GtkLevelBar *self)

"Sets the value of the inverted property", and move the documentation of what the property does to its gtk-doc block in class_init.

Review of attachment 224614 [details] [review]:

Sounds good - now I also understand why you pass inverted down to the draw methods, so you can ignore that previous comment :)

Review of attachment 224735 [details] [review]:

Fine to commit with the other patches.

Created attachment 225259 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar

Fixed the issues spotted by Cosimo

Review of attachment 225259 [details] [review]:

Looks good to commit after GTK is branched for 3.6.

Attachment 224614 [details] pushed as 5e55bf1 - level-bar: add support for RTL locales
Attachment 224735 [details] pushed as 0f36b16 - Add gdk version macros for 3.8
Attachment 225259 [details] pushed as e5de18c - level-bar: add an "inverted" property like GtkProgressBar