After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683252 - Offer logout option (modal) after selecting language
Offer logout option (modal) after selecting language
Status: RESOLVED DUPLICATE of bug 647373
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-03 08:25 UTC by drago01
Modified: 2012-09-14 06:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
userMenu: Renable logout for single user/session systems (1.51 KB, patch)
2012-09-03 08:25 UTC, drago01
rejected Details | Review
region: Offer logout option after changing language (3.36 KB, patch)
2012-09-03 10:24 UTC, drago01
none Details | Review
region: Offer logout option after changing language (3.67 KB, patch)
2012-09-03 10:27 UTC, drago01
none Details | Review

Description drago01 2012-09-03 08:25:49 UTC
See patch for rationale.
Comment 1 drago01 2012-09-03 08:25:52 UTC
Created attachment 223254 [details] [review]
userMenu: Renable logout for single user/session systems

We removed the logout option from the user menu on single user and single session setups because it is "useless".

This is not true though because we require a relogin to change language
settings without the option we basically require the user to reboot or powercycle the system in that case.

Also the region panel says "will be active on the next login" which is confusingwhen a logout option is not present.

So restore the menu entry and just hide switch user / session.
Comment 2 Jakub Steiner 2012-09-03 09:22:46 UTC
The problem at hand is not a missing logout, but the inability to apply a language change. Enabling log out in a a prominent place to address a corner case scenario would be inappropriate. 

I would much rather see effort to make the language change work without logging out, or providing a way to reload the session from the context of the change (the least appealing option being a modal/in app notification to log out).
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-03 09:26:35 UTC
(In reply to comment #2)
> The problem at hand is not a missing logout, but the inability to apply a
> language change. Enabling log out in a a prominent place to address a corner
> case scenario would be inappropriate. 
> 
> I would much rather see effort to make the language change work without logging
> out, or providing a way to reload the session from the context of the change
> (the least appealing option being a modal/in app notification to log out).

Damn near impossible because of the way the stack is built.
Comment 4 drago01 2012-09-03 09:27:54 UTC
(In reply to comment #2)
> The problem at hand is not a missing logout, but the inability to apply a
> language change. Enabling log out in a a prominent place to address a corner
> case scenario would be inappropriate. 
> 
> I would much rather see effort to make the language change work without logging
> out, or providing a way to reload the session from the context of the change
> (the least appealing option being a modal/in app notification to log out).

As discussed on IRC changing the language at runtime is kind of hard but having the a modal dialog prompt in the region panel sounds like a good solution without adding an otherwise useless option.
Comment 5 drago01 2012-09-03 10:24:13 UTC
Created attachment 223273 [details] [review]
region: Offer logout option after changing language
Comment 6 drago01 2012-09-03 10:27:37 UTC
Created attachment 223274 [details] [review]
region: Offer logout option after changing language

* Whitespace fixes
Comment 7 Bastien Nocera 2012-09-06 13:46:30 UTC
This is more pressing now, but it's a dupe of bug 647373.

I don't really like the separate logout dialogue, and would rather have a button show up prominently, in the user's selected language, asking them to logout.

*** This bug has been marked as a duplicate of bug 647373 ***