GNOME Bugzilla – Bug 682929
Don't use a global switch for all VPN connections
Last modified: 2013-03-23 12:51:34 UTC
Created attachment 222727 [details] Mockup for VPN connections in the network menu People are interested in individual VPN connections - that's what they want to turn on and off, not VPN in general. Also, it's a bit confusing to turn VPN on and then have one of the connections automatically activate. It would be better to have on/off switches for each VPN network that can be individually toggled. See the attached mockup.
Created attachment 222743 [details] Updated mockup - don't use a heading for VPN My original mockup was a bit inconsistent with how we handle other types of connections - with wired, we don't use a header for the type of interface, for example, and it's what I'd like to do for Mobile Broadband too (bug ). I think we should try to do the same here - it means the menu is a bit more compact, and it is consistent for different connection types.
Missing bug number in the above comment - it should be bug 658230.
(In reply to comment #1) > Created an attachment (id=222743) [details] > Updated mockup - don't use a heading for VPN > > My original mockup was a bit inconsistent with how we handle other types of > connections - with wired, we don't use a header for the type of interface, for > example, and it's what I'd like to do for Mobile Broadband too (bug ). I think > we should try to do the same here - it means the menu is a bit more compact, > and it is consistent for different connection types. Just a note: with wired we *do* use a header for the type of interface. See the screenshot in bug 677142. What happens is that device names are hidden when there is only one device, and that connection names are hidden when there is only one connection, which in the common case of autoconfigured eth0 results in "Wired [on|off]".
Created attachment 222790 [details] [review] NetworkMenu: don't use a global switch for all VPN connections Stop pretending that VPN is a NMDevice, and split the useful bits into a NMConnectionBased interface. Make each connection have its own switch menu item and handle its own status, and remove the VPN section title, which is no longer needed. This is above all the screenshield stuff, although rebasing should be possible. This also breaks UI freeze, so I'm pushing it only if it's considered high priority.
Created attachment 223100 [details] [review] NetworkMenu: don't use a global switch for all VPN connections Stop pretending that VPN is a NMDevice, and split the useful bits into a NMConnectionBased interface. Make each connection have its own switch menu item and handle its own status, and remove the VPN section title, which is no longer needed.
Comment on attachment 223100 [details] [review] NetworkMenu: don't use a global switch for all VPN connections >+ let pos = this._findConnection(vpnConnection.uuid); >+ if (pos > 0) { that needs to be >= Other than that, everything seems to work, after some minor rebasing issues. I'm attaching an updated patch.
Created attachment 226289 [details] [review] NetworkMenu: don't use a global switch for all VPN connections Stop pretending that VPN is a NMDevice, and split the useful bits into a NMConnectionBased interface. Make each connection have its own switch menu item and handle its own status, and remove the VPN section title, which is no longer needed.
Where do we stand on landing this ?
I believe the current patch is correct. If Giovanni is happy with it he should land it.
Let's go then!
*** Bug 696431 has been marked as a duplicate of this bug. ***