GNOME Bugzilla – Bug 682386
"make check" fails due to sys/resource.h not being available
Last modified: 2012-08-21 19:22:04 UTC
Created attachment 222062 [details] [review] win32: fix tests/sources.c Subject: [PATCH] win32: fix tests/sources.c "make check" was failing on sys/resource.h not being available on win32. Seeing that this test just spews some numbers on stdout whithout really testing anything we can safely replace them with similar enough numbers by relying on g_get_monotonic_time (). From jhbuild on Fedora 16 (running in a VirtualBox VM), before this patch: Add same-priority sources: 14 Remove in random order: 11 Add different-priority sources: 22 Remove in random order: 13 Add sources from threads: 482 Remove sources from threads: 207 From jhbuild on Fedora 16 (running in a VirtualBox VM), after this patch: Add same-priority sources: 23 Remove in random order: 14 Add different-priority sources: 35 Remove in random order: 20 Add sources from threads: 731 Remove sources from threads: 420 In MSYS bash on win32, after this patch: Add same-priority sources: 19 Remove in random order: 12 Add different-priority sources: 33 Remove in random order: 11 Add sources from threads: 83 Remove sources from threads: 30
Comment on attachment 222062 [details] [review] win32: fix tests/sources.c Sure, but trim down the commit message. No need for all this stuff: >From jhbuild on Fedora 16 (running in a VirtualBox VM), before this patch: >Add same-priority sources: 14 >Remove in random order: 11 >Add different-priority sources: 22 >Remove in random order: 13 >Add sources from threads: 482 >Remove sources from threads: 207 > >From jhbuild on Fedora 16 (running in a VirtualBox VM), after this patch: >Add same-priority sources: 23 >Remove in random order: 14 >Add different-priority sources: 35 >Remove in random order: 20 >Add sources from threads: 731 >Remove sources from threads: 420 > >In MSYS bash on win32, after this patch: >Add same-priority sources: 19 >Remove in random order: 12 >Add different-priority sources: 33 >Remove in random order: 11 >Add sources from threads: 83 >Remove sources from threads: 30 also, note that I just copied that code from another test, so presumably there are other tests that are being skipped on windows that could be unskipped if rewritten.
(In reply to comment #1) > (From update of attachment 222062 [details] [review]) > Sure, but trim down the commit message. No need for all this stuff: Done, also added a reference to this bug report while at it. > also, note that I just copied that code from another test, so presumably there > are other tests that are being skipped on windows that could be unskipped if > rewritten. Yeah, a lot of tests are not executed due to gtester not yet being ported to win32. Others are skipped in the Makefiles. One (tiny) step at a time :) Pushed as a3655be2111ee38839fe2a1fd001923d1d4ad7be