After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681827 - gdmflexiserver: don't lock the screen
gdmflexiserver: don't lock the screen
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks: 680231
 
 
Reported: 2012-08-14 10:59 UTC by Giovanni Campagna
Modified: 2012-08-16 19:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdmflexiserver: don't lock the screen (2.13 KB, patch)
2012-08-14 10:59 UTC, Giovanni Campagna
none Details | Review
Replace gdmflexiserver with a libgdm method (24.19 KB, patch)
2012-08-14 15:49 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-08-14 10:59:16 UTC
That is a job better handled by who calls the helper (that is,
gnome-shell)
Comment 1 Giovanni Campagna 2012-08-14 10:59:19 UTC
Created attachment 221126 [details] [review]
gdmflexiserver: don't lock the screen
Comment 2 Ray Strode [halfline] 2012-08-14 13:46:58 UTC
hmm, if user switching is defined as

- Lock up current session
- Allow user to login/unlock other session

then it seems kind of weird to offer a program that only does half of a user switch.

Actually, the whole gdmflexiserver command is weird. It used to be a general control interface to gdm, and do all sorts of stuff that it doesn't do anymore. 

A couple of possible ideas to consider if you're feeling motivated:

1) drop gdmflexiserver and move the functionality into libgdm
2) move gdmflexiserver into libexecdir

If you aren't feeling motivated or want to spend your motivation on more pressing things then just push attachment 221126 [details] [review] .
Comment 3 Giovanni Campagna 2012-08-14 15:49:35 UTC
Created attachment 221166 [details] [review]
Replace gdmflexiserver with a libgdm method

gdmflexiserver used to a be a generic interface to GDM, but now
it only does fast user switching. Move that functionality to libgdm
and kill the utility.
Comment 4 Ray Strode [halfline] 2012-08-14 16:53:50 UTC
Definitely going in the right direction (and i'm okay with this as is, if you want to commit it).  Additional idea:

Move the guts of this to the daemon as 

org.gnome.Manager.JumpToLoginScreen

(or so)

Then throw the api in the client object, so you'd have gdm_client_jump_to_login_screen (client).

Advantages: 

- More api consistency (client codes that does IPC with the daemon gets put in gdm-client.c).
- code consolidation (i believe gdm-manager.c already has functions for doing the consolekit/systemd communication
- Less synchronous work in the shell process.
Comment 5 Giovanni Campagna 2012-08-16 18:54:36 UTC
I pushed the client-side way for now, we can revisit in the future
(although I'm not sure involving the gdm daemon is the best way)
Attachment 221166 [details] pushed as 920b38e - Replace gdmflexiserver with a libgdm method
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-08-16 19:09:38 UTC
noooooo my monte carlo pi!