GNOME Bugzilla – Bug 681827
gdmflexiserver: don't lock the screen
Last modified: 2012-08-16 19:09:38 UTC
That is a job better handled by who calls the helper (that is, gnome-shell)
Created attachment 221126 [details] [review] gdmflexiserver: don't lock the screen
hmm, if user switching is defined as - Lock up current session - Allow user to login/unlock other session then it seems kind of weird to offer a program that only does half of a user switch. Actually, the whole gdmflexiserver command is weird. It used to be a general control interface to gdm, and do all sorts of stuff that it doesn't do anymore. A couple of possible ideas to consider if you're feeling motivated: 1) drop gdmflexiserver and move the functionality into libgdm 2) move gdmflexiserver into libexecdir If you aren't feeling motivated or want to spend your motivation on more pressing things then just push attachment 221126 [details] [review] .
Created attachment 221166 [details] [review] Replace gdmflexiserver with a libgdm method gdmflexiserver used to a be a generic interface to GDM, but now it only does fast user switching. Move that functionality to libgdm and kill the utility.
Definitely going in the right direction (and i'm okay with this as is, if you want to commit it). Additional idea: Move the guts of this to the daemon as org.gnome.Manager.JumpToLoginScreen (or so) Then throw the api in the client object, so you'd have gdm_client_jump_to_login_screen (client). Advantages: - More api consistency (client codes that does IPC with the daemon gets put in gdm-client.c). - code consolidation (i believe gdm-manager.c already has functions for doing the consolekit/systemd communication - Less synchronous work in the shell process.
I pushed the client-side way for now, we can revisit in the future (although I'm not sure involving the gdm daemon is the best way) Attachment 221166 [details] pushed as 920b38e - Replace gdmflexiserver with a libgdm method
noooooo my monte carlo pi!