Created attachment 219234 [details] [review]
GnomeWallClock: add ignore-date property

Created attachment 219237 [details] [review]
GnomeWallClock: add ignore-date property

In certain cases (such as the gnome-shell lock screen) we want
to show a clock without a date. This allows that, without duplicating
logic.

Previous fix was too quick and too dirty. This one works.

Review of attachment 219237 [details] [review]:

::: libgnome-desktop/gnome-wall-clock.c
@@ +238,3 @@
 			format_string = show_seconds ? _("%a %b %e, %R:%S")
 				: _("%a %b %e, %R");
+		} else if (show_date) {

Err...ok so reading this I was really confused because I don't think of the day of the week as part of the "date", and you're making this distinction between "full date" and "date".

I think it would be way, way clearer to call the option "show_time_only" or "show_clock_only".

Created attachment 219246 [details] [review]
GnomeWallClock: add ignore-date property

In certain cases (such as the gnome-shell lock screen) we want
to show a clock without a date. This allows that, without duplicating
logic.

Second try.

Review of attachment 219246 [details] [review]:

This looks unchanged from the previous one?  Did you forget to "git commit -a --amend"?  Or were you not intending to address my comment?

Created attachment 219282 [details] [review]
GnomeWallClock: add ignore-date property

In certain cases (such as the gnome-shell lock screen) we want
to show a clock without a date. This allows that, without duplicating
logic.

Sorry, yeah, I forgot to amend the commit...

Review of attachment 219282 [details] [review]:

Looks better, thanks!

Attachment 219282 [details] pushed as e5b7e53 - GnomeWallClock: add ignore-date property