After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679984 - Use GtkLevelBar
Use GtkLevelBar
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks: 691559
 
 
Reported: 2012-07-16 05:04 UTC by Cosimo Cecchi
Modified: 2013-01-11 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: port to GtkLevelBar (4.19 KB, patch)
2012-07-16 05:04 UTC, Cosimo Cecchi 		committed Details | Review
user-accounts: port to GtkLevelBar (6.83 KB, patch)
2012-07-16 05:04 UTC, Cosimo Cecchi 		committed Details | Review
shell: remove CcStrengthBar (18.40 KB, patch)
2012-07-16 05:04 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-07-16 05:04:24 UTC 
Now that GtkLevelBar is available in GTK, we should use it instead of the CcStrengthBar custom widget. See attached patches.
Comment 1 Cosimo Cecchi 2012-07-16 05:04:26 UTC 
Created attachment 218875 [details] [review]
power: port to GtkLevelBar
Comment 2 Cosimo Cecchi 2012-07-16 05:04:29 UTC 
Created attachment 218876 [details] [review]
user-accounts: port to GtkLevelBar

This also adds another out parameter to pw_strength(), which is a discrete
indication of the password strength (to be used with GtkLevelBar). The
advantage of having such a parameter back from pw_strength() is that we
can make sure the fill value and the hint string change at the same
time, for better consistency.
Comment 3 Cosimo Cecchi 2012-07-16 05:04:31 UTC 
Created attachment 218877 [details] [review]
shell: remove CcStrengthBar

Panels are all ported to GtkLevelBar instead.
Comment 4 Richard Hughes 2012-07-16 09:25:58 UTC 
Review of attachment 218875 [details] [review]:

From a power panel point of view, this looks fine, thanks. Best to get hadess to other patches tho.
Comment 5 Bastien Nocera 2012-07-16 10:32:47 UTC 
Attachment 218875 [details] pushed as b05591b - power: port to GtkLevelBar
Attachment 218876 [details] pushed as dfe03a1 - user-accounts: port to GtkLevelBar
Attachment 218877 [details] pushed as 1b3e877 - shell: remove CcStrengthBar

There's another "strength" bar in the sound panel, used for the microphone level, which includes
use of decay. That should stretch your API nicely :)
Comment 6 Bastien Nocera 2013-01-11 08:44:21 UTC 
Cosimo, will you look at using the strength bar in the sound panel?
Comment 7 Cosimo Cecchi 2013-01-11 16:14:14 UTC 
Yeah, I'd be interested in exploring that. It would require some GtkLevelBar subclass and/or special theming probably though - I think it's better to close this bug and file a new enhancement for the sound panel. I'll do that.