GNOME Bugzilla – Bug 678983
Favorite rooms are not saved
Last modified: 2013-01-24 14:15:31 UTC
Description of problem: Empathy doesn't save (or even recognize) if a chat room is marked as favorite. Version-Release number of selected component (if applicable): F17 empathy-3.4.2.1-1 How reproducible: Steps to Reproduce: 1. Start empathy 2. Add irc account 3. Enter channel and mark as favorite (via the menu) Actual results: Channel is marked as favorite (in the menu) and appears in the favorite channel list, but every other channel that is marked favorite (on other servers) does not appear in the list. The list is also not saved on quit Expected results: Favorite channels appear in the list and are connect automatically (if selected) Original Bug: https://bugzilla.redhat.com/show_bug.cgi?id=835805
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 646707 ***
Ok actually there are 2 bugs here: a) empathy can't notice favorite changes from empathy-chat (or the other way around). The proper way to fix this would be to rewrite the favorite code to use gsettings so we'll get notifications change; this is bug #646707 b) When marking a channel as favorite from empathy-chat, it's never saved. This one is easy to fix.
Created attachment 234305 [details] [review] chatroom-manager: save file when only the 'favorite' prop is changed Needed to save favorite changes from empathy-chat as it only changes this property.
Attachment 234305 [details] pushed as 8fd2851 - chatroom-manager: save file when only the 'favorite' prop is changed
I merged to 3.6 as well.