After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678665 - Update baobab for Vala 0.18
Update baobab for Vala 0.18
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-23 13:15 UTC by Allison Karlitskaya (desrt)
Modified: 2012-06-23 14:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adjust to Vala 0.18 bindings for GtkTreeStore (1.10 KB, patch)
2012-06-23 13:15 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2012-06-23 13:15:10 UTC 
Baobab needs to be branched and the 3.5 branch updated to work with Vala 0.18.  Patch attached for the second half of that.
Comment 1 Allison Karlitskaya (desrt) 2012-06-23 13:15:21 UTC 
Created attachment 217070 [details] [review]
Adjust to Vala 0.18 bindings for GtkTreeStore

The 'remove' method now takes its argument by reference (because it
modifies it to point at the next row after the removed one).

This was changed in https://bugzilla.gnome.org/show_bug.cgi?id=675402
Comment 2 Paolo Borelli 2012-06-23 14:16:59 UTC 
Just go ahead and commit, no need to branch... the new vala version has not seen a release, let alone a stable branch. Also bump the required vala version
Comment 3 Allison Karlitskaya (desrt) 2012-06-23 14:56:28 UTC 
Attachment 217070 [details] pushed as 81a2b08 - Adjust to Vala 0.18 bindings for GtkTreeStore