GNOME Bugzilla – Bug 676787
Update printing demo to use new print setting
Last modified: 2012-08-25 21:48:34 UTC
A new print setting has been added to reduce the amount of code needed in an application when changing the default filename in the print to file dialog. The printing demo should be updated to show the use of this new setting.
Created attachment 214910 [details] [review] Use new printer setting to reduce code required
Created attachment 214911 [details] [review] Use new printer setting to reduce code required Uploading the right patch this time. Whoops.
Created attachment 214912 [details] [review] Use new printer setting to reduce code required Updated patch to remove unused variables
Review of attachment 214912 [details] [review]: Thats perfekt.
The patch changes the file mode from 644 to 755 which is probably not wanted, should be fixed before committing.
Review of attachment 214912 [details] [review]: Code changes look fine. Just don't change the file mode, as was already pointed out.
Created attachment 222396 [details] [review] Use new printer setting to reduce code required Removed the permission changes. Can someone push the changes?
Review of attachment 222396 [details] [review]: Looks good now (at least it's the exact same than the previously accepted one, but without the mode change)
The following fix has been pushed: 2ab8e75 Use new printer setting to reduce code required by application
Created attachment 222437 [details] [review] Use new printer setting to reduce code required by application Updated demo to use new setting that allows an application to change the output filename without the need to create the uri itself.