After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676360 - build wacom panel conditionally
build wacom panel conditionally
Status: RESOLVED DUPLICATE of bug 676714
Product: gnome-control-center
Classification: Core
Component: Wacom
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Peter Hutterer
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-19 07:25 UTC by Michael Biebl
Modified: 2012-05-25 02:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build wacom support conditionally (2.04 KB, patch)
2012-05-19 07:26 UTC, Michael Biebl 		needs-work Details | Review

Description Michael Biebl 2012-05-19 07:25:02 UTC 
As some platforms don't have support for Wacom platforms, enable the wacom panel conditionally.
Comment 1 Michael Biebl 2012-05-19 07:26:47 UTC 
Created attachment 214437 [details] [review]
build wacom support conditionally
Comment 2 Michael Biebl 2012-05-19 07:29:30 UTC 
(In reply to comment #0)
> As some platforms don't have support for Wacom platforms, enable the wacom
> panel conditionally.

It basically does the same thing as bluetooth
Comment 3 Bastien Nocera 2012-05-19 09:26:18 UTC 
Review of attachment 214437 [details] [review]:

Not good enough. See the code used in bug 674935, in gnome-settings-daemon. libwacom is a hard requirement on platforms that support it.
Comment 4 Michael Biebl 2012-05-19 15:56:06 UTC 
(In reply to comment #3)
> Review of attachment 214437 [details] [review]:
> 
> Not good enough. See the code used in bug 674935, in gnome-settings-daemon.
> libwacom is a hard requirement on platforms that support it.

Why is it a hard requirement?
What makes wacom different from say bluetooth?
Comment 5 Peter Hutterer 2012-05-20 22:18:13 UTC 
libwacom is essentially a device database that provides the information that the drivers themselves dont have or expose (e.g. which stylis works with which tablet). Having said that, I'm not sure what's actually missing from the patch. 

The AC_MSG_NOTICE should probably say "wacom support (Wacom panel)" instead of libwacom.
Comment 6 Bastien Nocera 2012-05-21 10:39:21 UTC 
(In reply to comment #4)
<snip>
> What makes wacom different from say bluetooth?

It shouldn't be. Consider the bluetooth checks broken as well (the requirements are the same as the wacom panel ones).
Comment 7 Peter Hutterer 2012-05-25 02:02:22 UTC 
Antoine submitted a patch for this too that sues the switch statement similar to Bug 674935.

*** This bug has been marked as a duplicate of bug 676714 ***