After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675901 - Indicate output on volume OSD
Indicate output on volume OSD
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on: 674831
Blocks:
 
 
Reported: 2012-05-11 19:26 UTC by William Jon McCann
Modified: 2013-01-12 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update gvc submodule to git master (625 bytes, patch)
2013-01-11 22:43 UTC, Cosimo Cecchi
committed Details | Review
osd-window: show device description on volume OSD (10.44 KB, patch)
2013-01-11 22:43 UTC, Cosimo Cecchi
reviewed Details | Review
osd-window: show device description on volume OSD (10.60 KB, patch)
2013-01-12 00:04 UTC, Cosimo Cecchi
committed Details | Review

Description William Jon McCann 2012-05-11 19:26:34 UTC
It would be nice to see the sound output location listed on the volume change OSD. This is particularly useful if you are changing the volume because you can't hear something and don't realize that headphones are plugged in.

It would also be nice to maintain different volume level status for each output device. So when I plug in phones it goes back to non-ear-bleedingly loud.
Comment 1 William Jon McCann 2012-07-03 13:03:30 UTC
Lennart, this should be possible now right?
Comment 2 Bastien Nocera 2012-07-03 13:18:14 UTC
I was sure this was already filed, but I can't find it. It's dependent on the changes in gnome-control-center/PA 2.0 to get port information.
Comment 3 David Henningsson 2012-07-03 13:42:42 UTC
> It would also be nice to maintain different volume level status for each output
> device. So when I plug in phones it goes back to non-ear-bleedingly loud.

Given the jack detection stuff in PulseAudio 2.0 and Linux 3.3 (or above), this should be the rule rather than the exception (i e, it works for most newer desktops and laptops). See http://voices.canonical.com/david.henningsson/2011/09/29/independent-volume-for-headphones-and-speakers/ for some background info (although that article is Ubuntu centric, as of PA 2.0 and Linux 3.3, the same patches are upstream).

It should be independent of the new sound settings UI.
Comment 4 Bastien Nocera 2012-07-03 13:56:07 UTC
(In reply to comment #3)
<snip>
> It should be independent of the new sound settings UI.

The backend code for volume setting in gnome-settings-daemon uses the same code as gnome-control-center, so it's not really independent.
Comment 5 David Henningsson 2012-07-03 15:34:28 UTC
(In reply to comment #4)
> (In reply to comment #3)
> <snip>
> > It should be independent of the new sound settings UI.
> 
> The backend code for volume setting in gnome-settings-daemon uses the same code
> as gnome-control-center, so it's not really independent.

Okay. Just to clarify, the port information needed for OSD has been in the PulseAudio API for a long time, what's new in PulseAudio 2.0 (and Linux 3.3) is that the port will switch automatically for most people, so that e g when you plug your headphones in, PulseAudio's port will switch from "speaker" to "headphones".
Comment 6 Cosimo Cecchi 2013-01-11 22:43:52 UTC
Created attachment 233261 [details] [review]
Update gvc submodule to git master
Comment 7 Cosimo Cecchi 2013-01-11 22:43:56 UTC
Created attachment 233262 [details] [review]
osd-window: show device description on volume OSD

Only when the device is not the built-in/internal audio.
Comment 8 Cosimo Cecchi 2013-01-11 22:47:08 UTC
This is on top of the patches in bug 652321.
Comment 9 Bastien Nocera 2013-01-11 23:13:10 UTC
Comment on attachment 233261 [details] [review]
Update gvc submodule to git master

Looks good.
Comment 10 Bastien Nocera 2013-01-11 23:32:10 UTC
Review of attachment 233262 [details] [review]:

Looks good though you might want to run this by the designers first.

iOS has the name of the output above the icon, and I would personally have the output name as a fixed height, and ellipsise if needed.
Comment 11 Cosimo Cecchi 2013-01-12 00:04:02 UTC
Created attachment 233266 [details] [review]
osd-window: show device description on volume OSD

--

Better version, uses a similar logic to what we have in the Shell to show the headphones icon.
Comment 12 Bastien Nocera 2013-01-12 21:13:44 UTC
We can always change the location of the label later. Thanks again for the patch.