GNOME Bugzilla – Bug 675558
switch from lcms-1 to lcms-2-2.3
Last modified: 2012-09-03 18:06:34 UTC
Created attachment 213541 [details] [review] lcms-1 to lcms-2 changing code to lcms-2-2.3
*** Bug 674066 has been marked as a duplicate of this bug. ***
What's the difference between this version and the previous one? And why a new bug?
This is not a bug, it's an enhancement (I hope) There is no difference between this one and the old one, except that the patch file is "clean" (I hope) and made from the latest gimp-2.8.0 from git.
Why in cmsGetProfileInfoASCII (profile, cmsInfoModel, "en", "US", NULL, 0); is used hard LOCALE? I'm thinking that doesn't matter, but better ask :) (sorry for stupid questions (and Kali-English))
There have been claims on the gimpchat forum that this might affect the color management performance problem, bug #645345. Would be nice to have some profiling data of the comparison.
I have no profiling data, my developing environment is windows with netbeans c/c++. I don't think, that lcms 2.3 is significantly faster than lcms 1.9, but it is newer, so if there are improvements in lcms 2.x (and the speed problem is known to the lcms developer), gimp can get profit from it. The "en"/"US" locale is an idea from the lcms API, because these locales are implemented in most profiles.
Cleaned up a bit and pushed to master: commit 8bbfc9e5cf4728b9cafc4edf32ab52c32375f9b7 Author: Michael Natterer <mitch@gimp.org> Date: Mon Sep 3 20:03:53 2012 +0200 Bug 675558 - switch from lcms-1 to lcms-2 Applied modified patch from Hartmut Kuhse which ports to lcms-2. configure.ac | 4 +-- modules/color-selector-cmyk-lcms.c | 51 ++++++++++++++++++++++++---- modules/display-filter-lcms.c | 88 ++++++++++++++++++++++++++++++++++++++---------- modules/display-filter-proof.c | 38 +++++++++++++++++---- plug-ins/common/lcms.c | 83 +++++++++++++++++++++++++++++++++++---------- plug-ins/file-jpeg/jpeg-load.c | 10 +++--- 6 files changed, 219 insertions(+), 55 deletions(-)