GNOME Bugzilla – Bug 675134
shmsrc: add an shm-area-name property
Last modified: 2015-04-02 22:14:28 UTC
Created attachment 213096 [details] [review] shmsrc: add an shm-area-name property The shm-area-property tells the name of the shm area used by the element. This is useful for cases where shmsink is not able to clean up (calling shm_unlink()), e.g. if it is in a sandbox. For this patch, I had to change a bit the logic in shmpipe.c: the presence of shm_area_name was used to make the distinction between a reading or writing pipe, I've put an is_writer boolean there instead, so that I can ensure that shm_area_name is here with the correct value when we are in reading mode. Then it's just a matter of adding an accessor and using it to export a property in shmsrc.
Review of attachment 213096 [details] [review]: ::: sys/shm/gstshmsrc.c @@ +208,3 @@ + g_value_set_string (value, sp_get_shm_area_name (self->pipe->pipe)); + else + g_value_set_string (value, NULL); The else bit here is not necessary
Created attachment 213276 [details] [review] shmsink: add an shm-area-name property New version removing useless g_value_set_string() call.
Olivier ?
Attachment 213276 [details] pushed as 48880ea - shmsink: add an shm-area-name property
Thanks.