GNOME Bugzilla – Bug 675076
Login box grows a few pixels when selecting different users
Last modified: 2012-07-18 21:58:46 UTC
When the login box presents more than one user it is possible to use the up/down arrows keys to select between them. However every time a new user is selected the login box grows horizontally by a few pixels. This is with gdm-3.4.1.
*** Bug 675407 has been marked as a duplicate of this bug. ***
*** Bug 675831 has been marked as a duplicate of this bug. ***
*** Bug 676792 has been marked as a duplicate of this bug. ***
*** Bug 678219 has been marked as a duplicate of this bug. ***
Created attachment 218736 [details] [review] loginDialog: Scale focusBin instead of resizing it When setting an explicit size as we do currently, rounding errors (for instance introduced by padding not specified in pixels) may affect the parent's size allocation, e.g. making it shrink or grow each time the size is reset. Rather than taking care of possible rounding errors, set up focusBin to take up the available width and use scaling for the animation.
Works fine in my testing, thanks
Review of attachment 218736 [details] [review]: This will mean that things like borders and rounded radiuses will get squashed and be at the wrong aspect ratio. No.
(In reply to comment #7) > This will mean that things like borders and rounded radiuses will get squashed > and be at the wrong aspect ratio. No. Border-radius, seriously? We are talking about a horizontal line with a height of 2px (yes, I'm making some assumptions, but so does the existing code with regard to which actors have padding and which don't)
(In reply to comment #8) > Border-radius, seriously? We are talking about a horizontal line with a height > of 2px (yes, I'm making some assumptions, but so does the existing code with > regard to which actors have padding and which don't) "Everybody else makes broken assumptions, so I should do it too!"
Review of attachment 218736 [details] [review]: OK.
Created attachment 218901 [details] [review] loginDialog: Scale focusBin instead of resizing it (In reply to comment #9) > "Everybody else makes broken assumptions, so I should do it too!" I would define "broken" as "wrong/invalid", which is not the case for either assumption; anyway, here's an alternative patch which adds complexity for additional (probably never needed) style flexibility ...
So, can we get this landed ?
Comment on attachment 218736 [details] [review] loginDialog: Scale focusBin instead of resizing it (oops, didn't mean to mark this one obsolete)
Review of attachment 218736 [details] [review]: You might not have noticed that I marked the simpler one ACN.
Attachment 218736 [details] pushed as f46a165 - loginDialog: Scale focusBin instead of resizing it Yes, but you were implying that the patch was a bad hack, which is why I wrote an alternative. Let's go with the simple approach then.