GNOME Bugzilla – Bug 673527
Addressbook bulk methods are broken
Last modified: 2012-04-05 09:46:39 UTC
It appears that the addressbook bulk methods in EBookClient were broken. As a consequence, the following test app is no longer working: tests/libebook/test-bulk-methods (freezes on bulk removal) It used git bisect and identified the commit that broke it: --- commit e144f7b5b0aba6e7903c3c98c4db792fddbf9c50 Author: Tristan Van Berkom <tristan.van.berkom@gmail.com> Date: Fri Jul 22 20:05:21 2011 -0400 Make local addressbook backend store image data as URIs. --- I haven't had time to figure out why the commit broke batch methods yet but at least we know where to look.
Created attachment 211355 [details] [review] Proposed patch Now the tests/libebook/test-bulk-methods test is passing again. The issue was caused by the maybe_delete_unused_uris() doing database requests from within a transaction but without using the transaction handle.
Thanks for the patch. it looks good (and works on the test, as you said). Please commit to both master and gnome-3-4.
Pushed to master: c3b75f197f07d98a52559c726f70f5faf9f952f3 and gnome-3-4: d9eb594a188804e4d15c270bbd1f8f0b8b2e2713 Thanks for reviewing.