After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672947 - GtkEntryCompletion sizing/position fixes
GtkEntryCompletion sizing/position fixes
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 672927
 
 
Reported: 2012-03-27 20:04 UTC by Cosimo Cecchi
Modified: 2012-05-04 19:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
entry-completion: don't subtract entry borders from popup allocation (1.77 KB, patch)
2012-03-27 20:04 UTC, Cosimo Cecchi
committed Details | Review
entry-completion: set size request on the toplevel window (1.74 KB, patch)
2012-03-27 20:04 UTC, Cosimo Cecchi
committed Details | Review
web completion with the patch applied (59.98 KB, image/png)
2012-03-27 20:09 UTC, Cosimo Cecchi
  Details
web completion with no patch (60.24 KB, image/png)
2012-03-27 20:10 UTC, Cosimo Cecchi
  Details
web completion with the patch applied (59.98 KB, image/png)
2012-03-27 20:12 UTC, Cosimo Cecchi
  Details

Description Cosimo Cecchi 2012-03-27 20:04:30 UTC
See attached patches
Comment 1 Cosimo Cecchi 2012-03-27 20:04:34 UTC
Created attachment 210722 [details] [review]
entry-completion: don't subtract entry borders from popup allocation

The completion popup should be aligned with the GtkEntry allocation, not
less than that.
Comment 2 Cosimo Cecchi 2012-03-27 20:04:37 UTC
Created attachment 210723 [details] [review]
entry-completion: set size request on the toplevel window

Instead of setting it on the child scrolled window. This is needed
because the whole window's allocation must be equal to the one of the
entry (in case the popup-set-width property is TRUE); if we set the size
request on a children of the window, there might be other children with
borders/paddings in between the toplevel and the child we set the size
request too, which will break alignment.
Comment 3 Cosimo Cecchi 2012-03-27 20:09:46 UTC
Created attachment 210725 [details]
web completion with the patch applied
Comment 4 Cosimo Cecchi 2012-03-27 20:10:26 UTC
Created attachment 210726 [details]
web completion with no patch
Comment 5 Cosimo Cecchi 2012-03-27 20:12:00 UTC
Created attachment 210727 [details]
web completion with the patch applied

Sorry for the noise, I mixed up the screenshots
Comment 6 Matthias Clasen 2012-05-04 02:31:57 UTC
Review of attachment 210723 [details] [review]:

makes sense
Comment 7 Matthias Clasen 2012-05-04 02:32:58 UTC
Review of attachment 210722 [details] [review]:

ok
Comment 8 Cosimo Cecchi 2012-05-04 19:43:54 UTC
Attachment 210722 [details] pushed as 644070b - entry-completion: don't subtract entry borders from popup allocation
Attachment 210723 [details] pushed as 5a8e2b5 - entry-completion: set size request on the toplevel window