GNOME Bugzilla – Bug 672772
glib-single-include: glib/gbytes.h missing
Last modified: 2012-03-29 22:53:12 UTC
> I did a test rebuild of the Debian archive and found 125 packages which > failed to build with the new glib (2.31.22) [1]. > I'm going to file bug reports against those packages, but I wonder what > the now recommended practise is, as I found the following headers which > don't generate that error: Thanks for doing this work ! > glib/gbytes.h This is an oversight. Please file a bug against glib for it (or just commit the obvious fix). > glib/gi18n.h > glib/gi18n-lib.h > glib/gprintf.h > glib/gstdio.h These are all exceptions, for various reasons that are explained in the docs somewhere. [1] http://people.debian.org/~biebl/glib-single-include/
fwiw, the bugs have been filed now: http://bugs.debian.org/cgi-bin/pkgreport.cgi?users=pkg-gnome-maintainers@lists.alioth.debian.org;tag=glib-single-include
I've also noticed that glibconfig.h uses #include <glib/gmacros.h>, which will trigger the error. Is glibconfig.h no longer supposed to be included directly?
glibconfig.h gets pulled in via glib.h -> gtypes.h -> glibconfig.h so no, it is not supposed to be included individually either
I've added the single-include guard to gbytes.h