After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672321 - Placeholder icon when dragging between workspaces is fuzzy
Placeholder icon when dragging between workspaces is fuzzy
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-18 01:25 UTC by Dylan McCall
Modified: 2012-03-18 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the overview with workspace placeholder icon visible (432.03 KB, image/png)
2012-03-18 01:25 UTC, Dylan McCall
  Details
tests: Fix font color for tests (689 bytes, patch)
2012-03-18 09:57 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
tests: Add a cogl rendering option to the background-size test (3.26 KB, patch)
2012-03-18 09:57 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
tests: Refactor background-size test to support non-square containers (3.96 KB, patch)
2012-03-18 09:57 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
st-theme-node-drawing: Fix implementation of cover and contain (1.62 KB, patch)
2012-03-18 09:57 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Dylan McCall 2012-03-18 01:25:05 UTC
Created attachment 210024 [details]
Screenshot of the overview with workspace placeholder icon visible

In the overview, when I drag a window or an application between two workspaces in the overview, a placeholder icon (dash-placeholder.svg) appears. The icon appears to be rendered at the same resolution as it appears in the dash, but it is scaled upwards so it appears very fuzzy.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-03-18 09:57:13 UTC
Created attachment 210035 [details] [review]
tests: Fix font color for tests

Since the GNOME Shell style cleanup, all text is white. Fix that
in the test cases.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-18 09:57:15 UTC
Created attachment 210036 [details] [review]
tests: Add a cogl rendering option to the background-size test

Right now we only test the cairo rendering path
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-03-18 09:57:18 UTC
Created attachment 210037 [details] [review]
tests: Refactor background-size test to support non-square containers
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-03-18 09:57:21 UTC
Created attachment 210038 [details] [review]
st-theme-node-drawing: Fix implementation of cover and contain

The math was incorrect for non-square containers
Comment 5 drago01 2012-03-18 10:40:56 UTC
Review of attachment 210035 [details] [review]:

Looks good.
Comment 6 drago01 2012-03-18 10:47:33 UTC
Review of attachment 210036 [details] [review]:

::: tests/interactive/background-size.js
@@ +38,3 @@
+        obin.connect_after('paint', function(actor) {
+            // For some strange reason, croco's 'green'
+            // is #008000

That's odd ... we should just fix that instead see bug 672332
Comment 7 drago01 2012-03-18 10:50:00 UTC
Review of attachment 210037 [details] [review]:

Subject is kind of long otherwise fine.
Comment 8 drago01 2012-03-18 10:50:41 UTC
Review of attachment 210038 [details] [review]:

Looks good.
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-03-18 13:34:08 UTC
Attachment 210035 [details] pushed as 1626d9f - tests: Fix font color for tests
Attachment 210036 [details] pushed as 1c60aa5 - tests: Add a cogl rendering option to the background-size test
Attachment 210037 [details] pushed as 1983097 - tests: Refactor background-size test to support non-square containers
Attachment 210038 [details] pushed as 3dbf064 - st-theme-node-drawing: Fix implementation of cover and contain


Since the Croco patch was accepted, I changed the constant to (0, 1, 0, 1).