After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671305 - Recent gtk+ changes require GDK_SCROLL_MASK to be set explicitly
Recent gtk+ changes require GDK_SCROLL_MASK to be set explicitly
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.31.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
: 671523 671554 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-03-04 12:05 UTC by Gert Kulyk
Modified: 2012-03-08 21:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (703 bytes, patch)
2012-03-04 12:05 UTC, Gert Kulyk 		accepted-commit_now Details | Review

Description Gert Kulyk 2012-03-04 12:05:27 UTC 
Created attachment 208947 [details] [review]
Proposed patch

Current gtk+ (3.3.17+) requires GDK_SCROLL_MASK to be set explicitly. Selecting for button press/release doesn't suffice anymore to get scroll events.
Comment 1 Christian Persch 2012-03-04 12:22:41 UTC 
If this worked in previous gtk versions, then this would seem to be a gtk bug...
Comment 2 Gert Kulyk 2012-03-04 12:55:21 UTC 
I'm not a gtk developer nor an experienced programmer, but as far as I understand the gtk+ changelog it is an intended change, not a gtk bug.
Comment 3 Gert Kulyk 2012-03-04 13:09:08 UTC 
s/changelog/gitlog

This is related to the recent addition of GDK_SMOOTH_SCROLL_MASK.
Comment 4 Christian Persch 2012-03-04 17:37:12 UTC 
Comment on attachment 208947 [details] [review]
Proposed patch

This is unfortunate, but adding GDK_SCROLL_MASK to the events looks right anyway, and shouldn't break anything for gtk < 3.3, so let's get this in.

Please commit to the vte-next and vte-0-32 branches.
Comment 5 Christian Persch 2012-03-07 12:19:25 UTC 
*** Bug 671523 has been marked as a duplicate of this bug. ***
Comment 6 Christian Persch 2012-03-07 13:42:52 UTC 
*** Bug 671554 has been marked as a duplicate of this bug. ***
Comment 7 Martin Pitt 2012-03-08 09:32:34 UTC 
I confirm that this fixes mouse scrolling in gnome-terminal again. Thanks for the patch!