GNOME Bugzilla – Bug 670150
docDisplay: Remove "Recent Items" search provider
Last modified: 2012-08-27 01:44:19 UTC
Once bug 662453 lands, there will be significant overlap between results provided by gnome-documents and the existing GtkRecent provider; kill the latter, even though the rest of finding+reminding applications are not ready yet ...
Created attachment 207683 [details] [review] docDisplay: Remove "Recent Items" search provider Although not all "Finding and reminding" applications are ready yet, the integration with gnome-documents' search results overlaps enough with the "Recent Items" provider to justify its removal.
Can we ensure there won't be any regression regarding files that are not handled by gnome-documenst? Wouldn't it be possible to simply exclude files that are returned by the gnome-documents search provider, but still show the others?
Review of attachment 207683 [details] [review]: Aaahhh... fresh code removal, just what I love in the morning. Additionally, if I'm reading this correctly, a large part of st-texture-cache related to loading recent thumbnails seems like it can be trashed too, since this was the last user. And that means that we don't have to depend on gnome-desktop (until we port to GnomeDesktop.WallClock)
Created attachment 208168 [details] [review] st: Remove thumbnail functions from TextureCache They were only used by the recent item search, which has been removed. Follow-up cleanup, fun stuff!
Review of attachment 208168 [details] [review]: Yes please.
Comment on attachment 207683 [details] [review] docDisplay: Remove "Recent Items" search provider Attachment 207683 [details] pushed as ac78a1e - docDisplay: Remove "Recent Items" search provider
Attachment 208168 [details] pushed as 80eac73 - st: Remove thumbnail functions from TextureCache
It appears that document search does not work at all in the Gnome Shell 3.4.1 Activities Search on Ubuntu or Fedora. A number of people have pointed to this thread as a basis for problems with searching documents. For example, see https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/970686 Ubuntu and Fedora users have had six months without this functionality.