GNOME Bugzilla – Bug 665526
prefer native threads on win32
Last modified: 2012-05-09 10:49:11 UTC
Created attachment 202736 [details] [review] patch: configure.in - prefer win32 native threads when available I came up with patch originally to work around https://bugzilla.gnome.org/show_bug.cgi?id=599241 , however it turns out this has a fix It still seems like it would be better to use the native Win32 threads API when available rather than using it through the pthread wrapper, since the code is already there. This has been suggested before: https://bugzilla.gnome.org/show_bug.cgi?id=593857 https://bugzilla.gnome.org/show_bug.cgi?id=588352
Comment on attachment 202736 [details] [review] patch: configure.in - prefer win32 native threads when available [Setting "patch" flag and correcting mime type]
Thanks André for the bugilla work, it does help !!! Sam, yes I agree that going though native thread support when available and pthreads are not explicitely asked for sounds a better option. The patch looks sensible, there is just a bug if test -z "THREADS_W32"; then should be if test -z "$THREADS_W32"; then to avoid disabling thread support on all non-Windows targets, but once fixed that works fine :-) So I applied the patch and commited after that small fix :) http://git.gnome.org/browse/libxml2/commit/?id=115581ae2d3e35ddb7c43c50aacfa98193be6b72 thanks ! Daniel