After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664428 - Use GtkGrid instead of GtkBox
Use GtkGrid instead of GtkBox
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other All
: Normal minor
: 3.2
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-20 17:55 UTC by David King
Modified: 2011-11-26 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (18.48 KB, patch)
2011-11-23 18:32 UTC, Lucas Baudin
none Details | Review
screenshot of avatar chooser test (9.43 KB, image/png)
2011-11-24 10:08 UTC, David King
  Details
second patch (41.06 KB, patch)
2011-11-24 19:08 UTC, Lucas Baudin
needs-work Details | Review
screenshot of Cheese main window (161.11 KB, image/png)
2011-11-25 11:08 UTC, Patricia Santana Cruz
  Details
third patch (18.64 KB, patch)
2011-11-26 09:34 UTC, Lucas Baudin
committed Details | Review

Description David King 2011-11-20 17:55:30 UTC
GtkBox will likely be deprecated soon, so it would be useful to convert uses of GtkBox in Cheese to GtkGrid soon.
Comment 1 Lucas Baudin 2011-11-23 18:32:07 UTC
Created attachment 202017 [details] [review]
patch

Here is a patch, which should fix this problem. I didn't replace GtkBox of dialogs (because it can only causes problem I suppose?). Tell me if there are any problems :) (maybe I forgot something?)

Thanks for mentoring :)
Comment 2 David King 2011-11-24 10:08:28 UTC
Created attachment 202048 [details]
screenshot of avatar chooser test

(In reply to comment #1)
> Created an attachment (id=202017) [details] [review]
> patch

Thanks!

> Here is a patch, which should fix this problem. I didn't replace GtkBox of
> dialogs (because it can only causes problem I suppose?).

That was the correct thing to do, thanks.

>Tell me if there are
> any problems :) (maybe I forgot something?)

Cheese itself seems fine, but the avatar chooser seems slightly broken. Maybe the CheeseWidget is not set to expand? If you build Cheese, you can find the CheeseAvatarChooser test in tests/cheese-test-chooser. When you run it, you will see that the video preview is very small, as in the attached screenshot. Once that is fixed, I think that the patch is ready to merge.

> Thanks for mentoring :)

Thanks for contributing!
Comment 3 Lucas Baudin 2011-11-24 19:08:03 UTC
Created attachment 202083 [details] [review]
second patch

Ah, yes, I forgot to test this... Here is an updated patch :)
Comment 4 Patricia Santana Cruz 2011-11-25 11:08:49 UTC
Created attachment 202121 [details]
screenshot of Cheese main window

The avatar chooser works now correctly with the last version of the patch that was submitted, but then, the main window does not display the camara any more. Have a look to the attached screenshot for more details.
Comment 5 Patricia Santana Cruz 2011-11-25 11:10:07 UTC
Comment on attachment 202083 [details] [review]
second patch

Avatar chooser is working fine with this version of the patch, but now the camera is not displayed in the main window. Please, have a look to the screenshot I attached in my last comment
Comment 6 Lucas Baudin 2011-11-26 09:34:12 UTC
Created attachment 202171 [details] [review]
third patch

So, this one should work :)
Comment 7 David King 2011-11-26 17:29:50 UTC
Comment on attachment 202171 [details] [review]
third patch

Pushed to master as commit 4317b88eea3e5f7537a97a5e2714caf252a9f9d6.