After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663461 - A few minor issues
A few minor issues
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-05 17:21 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2018-07-14 00:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
StTextureCache: Obey cache policy in st_texture_cache_load (1.79 KB, patch)
2011-11-05 17:21 UTC, Jasper St. Pierre (not reading bugmail)
needs-work Details | Review
StThemeNode: Fix a GCC warning (1.17 KB, patch)
2011-11-05 17:21 UTC, Jasper St. Pierre (not reading bugmail)
needs-work Details | Review
st-texture-cache: Obey cache policy in st_texture_cache_load (1.89 KB, patch)
2012-02-14 22:23 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
st-theme-node: Fix an accidental shadow (1.22 KB, patch)
2012-02-14 22:24 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
st-texture-cache: Obey cache policy in st_texture_cache_load (1.89 KB, patch)
2012-02-14 22:27 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-11-05 17:21:38 UTC
See patches, nothing major.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-11-05 17:21:40 UTC
Created attachment 200763 [details] [review]
StTextureCache: Obey cache policy in st_texture_cache_load
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-11-05 17:21:43 UTC
Created attachment 200764 [details] [review]
StThemeNode: Fix a GCC warning
Comment 3 Owen Taylor 2012-01-25 17:07:50 UTC
Review of attachment 200763 [details] [review]:

::: src/st/st-texture-cache.c
@@ +976,3 @@
     }
+
+  return cogl_handle_ref (texture);

- calls cogl_handle_ref() on null in the case of error
- leaks the texture when policy is not FOREVER by ref'ing it when it shouldn't
Comment 4 Owen Taylor 2012-01-25 17:11:51 UTC
Review of attachment 200764 [details] [review]:

Commit message should give some idea of what gcc warning is being fixed, and maybe for what gcc version - is this with our default compiler flags (I don't see a warning and we don't include -Wshadow by default)? Patch itself looks OK as a cleanup
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-02-14 22:23:42 UTC
Created attachment 207593 [details] [review]
st-texture-cache: Obey cache policy in st_texture_cache_load

Ah, I see.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-02-14 22:24:09 UTC
Created attachment 207594 [details] [review]
st-theme-node: Fix an accidental shadow

This may cause a gcc warning, nothing serious.



Huh. I'm not hitting the warning anymore... I was at one time, I swear.
Oh well, the shadow cleanup is still worthwhile IMO.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-02-14 22:27:16 UTC
Created attachment 207595 [details] [review]
st-texture-cache: Obey cache policy in st_texture_cache_load

Wait, no, that's wrong. This should be correct.
Comment 8 Florian Müllner 2018-07-13 19:55:50 UTC
Comment on attachment 207594 [details] [review]
st-theme-node: Fix an accidental shadow

Attachment 207594 [details] was obsoleted by commit a025b151ef.
Comment 9 Florian Müllner 2018-07-14 00:22:57 UTC
Attachment 207595 [details] pushed as 50e849a - st-texture-cache: Obey cache policy in st_texture_cache_load