GNOME Bugzilla – Bug 662662
Re-disable GLib deprecated
Last modified: 2012-04-23 12:03:57 UTC
I'm going to disable GLib deprecation warnings in master. I don't want to bump the dep, and so makes things harder for contributors, without good reason. But we should re-enable this warning during this cycle.
Created attachment 199933 [details] [review] Depends on GLib 2.31.0 We need it to replace some deprecated API.
Created attachment 199934 [details] [review] empathy-chat: disable GLib deprecation Thanks GLib for deprecating GCompletion without providing a replacement...
Created attachment 199935 [details] [review] Revert "Disable GLib deprecation warnings for now" This reverts commit 5ccd14f47a13b5a0d00a48ec85b4c9dab6eb3bc9.
Created attachment 199936 [details] [review] stop using g_thread_init It has been deprecated in GLib 2.31.
Created attachment 199937 [details] [review] Allocate GMutex on the stack g_mutex_new() has been deprecated in GLib 2.31.
Review of attachment 199933 [details] [review]: ++ but can this wait until after Friday?
Review of attachment 199934 [details] [review]: ::: libempathy-gtk/empathy-chat.c @@ +32,3 @@ +/* for GCompletion */ +#undef G_DISABLE_DEPRECATED Do we still need this?
Review of attachment 199935 [details] [review]: ++
Review of attachment 199936 [details] [review]: ++
Review of attachment 199937 [details] [review]: ++
(In reply to comment #6) > Review of attachment 199933 [details] [review]: > > ++ but can this wait until after Friday? Sure; I'm not planning to merge it right now.
Merged to master. I didn't bump GLIB_VERSION_MIN_REQUIRED as we still use GValueArray which has been deprecated as well. Attachment 199936 [details] pushed as ee2e583 - stop using g_thread_init Attachment 199937 [details] pushed as 2c3892e - Allocate GMutex on the stack
Closing this bug. The last blocking bits is GValueArray which are tracked down in bug #673843