Bug 661734 – Report insufficient balance for calls

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 661734 - Report insufficient balance for calls


Summary:	Report insufficient balance for calls


Status:	RESOLVED FIXED

Product:	empathy
Classification:	Core
Component:	VoIP
Version:	3.1.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:	empathy-maint

URL:
Whiteboard:

Depends on:
Blocks:	646682

Reported:	2011-10-14 05:37 UTC by Danielle Madeley
Modified:	2011-10-21 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
updated patch (11.05 KB, patch) 2011-10-21 06:31 UTC, Danielle Madeley	accepted-commit_now	Details \| Review

Description Danielle Madeley 2011-10-14 05:37:30 UTC

We need to support the insufficient balance error for calls with a way to offer the user to top-up via ManageCreditURI.

I rebased and squashed this old branch from Emilio:

http://cgit.collabora.com/git/user/danni/empathy.git/log/?h=balance-errors

It could probably do with designer input (also porting to use the factory, rather than re-preparing the Connection).

Comment 1 Danielle Madeley 2011-10-14 06:22:23 UTC

Updated with some small fixes, which haven't been tested, because I can't seem to compile empathy-call :-/

Comment 2 Guillaume Desmottes 2011-10-14 17:36:58 UTC

I tried it and hit this crash:


Program received signal SIGSEGV, Segmentation fault.
0x0000000000434523 in empathy_call_window_state_changed_cb (handler=0x707cb0, state=TPY_CALL_STATE_PENDING_RECEIVER, reason=0x1c53410 "", self=0x0)
    at empathy-call-window.c:3186
3186	  EmpathyCallWindowPriv *priv = GET_PRIV (self);
(gdb) bt

+ Trace 228804

#0 empathy_call_window_state_changed_cb
at empathy-call-window.c line 3186
#1 ffi_call_unix64
from /usr/lib/libffi.so.5
#2 ffi_call
from /usr/lib/libffi.so.5
#3 g_cclosure_marshal_generic
at gclosure.c line 1147
#4 g_closure_invoke
at gclosure.c line 774
#5 signal_emit_unlocked_R
at gsignal.c line 3272
#6 g_signal_emit_valist
at gsignal.c line 3003
#7 g_signal_emit
at gsignal.c line 3060
#8 on_call_state_changed_cb
at empathy-call-handler.c line 204
#9 _tpy_marshal_VOID__UINT_UINT_BOXED_BOXED
at _gen/signals-marshal.c line 431
#10 g_closure_invoke
at gclosure.c line 774
#11 signal_emit_unlocked_R
at gsignal.c line 3272
#12 g_signal_emit_valist
at gsignal.c line 3003
#13 g_signal_emit
at gsignal.c line 3060
#14 on_call_state_changed_cb
at call-channel.c line 280
#15 _tpy_cli_channel_type_call_invoke_callback_for_call_state_changed
at _gen/cli-call-body.h line 3058
#16 tp_proxy_signal_invocation_run
at proxy-signals.c line 266
#17 g_idle_dispatch
at gmain.c line 4801
#18 g_main_dispatch
at gmain.c line 2441
#19 g_main_context_dispatch
at gmain.c line 3011
#20 g_main_context_iterate
at gmain.c line 3089
#21 g_main_loop_run
at gmain.c line 3297
#22 gtk_main
at gtkmain.c line 1362
#23 gtk_application_run_mainloop
at gtkapplication.c line 115
#24 g_application_run
at gapplication.c line 1323
#25 main
at empathy-call.c line 253

Comment 3 Danielle Madeley 2011-10-21 06:31:41 UTC

Created attachment 199614 [details] [review]
updated patch

Rebased, fixed and tested. 2 new commits. The crash was a missing argument to g_signal_new().

Also swapped the order of the buttons so that Top Up is on top of Close. Makes more sense that way IMO.

Comment 4 Guillaume Desmottes 2011-10-21 08:13:30 UTC

Review of attachment 199614 [details] [review]:

Looks good (I didn't test it).

Comment 5 Danielle Madeley 2011-10-21 21:47:48 UTC

Cool. Merged.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.