After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659948 - the "Other media..." dialog opens empty the second time
the "Other media..." dialog opens empty the second time
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Removable Media
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-23 14:40 UTC by Sebastien Bacher
Modified: 2012-03-05 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media: handle dialog closing consistently (1.32 KB, patch)
2011-09-24 00:28 UTC, Matthias Clasen
committed Details | Review

Description Sebastien Bacher 2011-09-23 14:40:39 UTC
Using GNOME 3.1.92:
- open the removable media dialog
- click on "other media..."
- hit the "esc" key to close the dialog
- click on "other media..." again

The dialog display is small and empty
Comment 1 Matthias Clasen 2011-09-24 00:28:34 UTC
Created attachment 197380 [details] [review]
media: handle dialog closing consistently

The 'Other media' dialog is just hidden when the close button is
clicked (so that it can be shown again), but when closing it with
the Escape key, it gets destroyed and an attempt to bring it up
again just shows a sad empty little square.

https://bugzilla.gnome.org/show_bug.cgi?id=659940
Comment 2 Cosimo Cecchi 2011-09-25 20:02:24 UTC
Review of attachment 197380 [details] [review]:

Looks good to me.
Comment 3 André Klapper 2011-11-29 15:07:16 UTC
ping - can the patch go into master now that there is a gnome-3-2 branch?
Comment 4 Robert Roth 2011-12-01 21:33:03 UTC
As this problem has been fixed for 3.2.0, I will close this as fixed. The commit fixing this was http://git.gnome.org/browse/gnome-control-center/commit/panels/media/cc-media-panel.c?id=b374d64e6bfc39dc2f1699b4cb5bb9f4db86cdb9
Comment 5 Sebastien Bacher 2012-03-05 13:34:27 UTC
Reopening, the commit pointed is a different issue, the bug is still there in 3.3.90, the patch should still be commited
Comment 6 Bastien Nocera 2012-03-05 14:04:46 UTC
Attachment 197380 [details] pushed as 20f242b - media: handle dialog closing consistently