After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651253 - atk using ATK_DISABLE_DEPRECATED references deprecated symbol
atk using ATK_DISABLE_DEPRECATED references deprecated symbol
Status: RESOLVED DUPLICATE of bug 573539
Product: atk
Classification: Platform
Component: atk
git master
Other All
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-05-27 13:47 UTC by Jasper Lievisse Adriaanse
Modified: 2013-12-11 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Wrap function call and implementation (1.25 KB, patch)
2011-05-27 13:47 UTC, Jasper Lievisse Adriaanse 		none Details | Review

Description Jasper Lievisse Adriaanse 2011-05-27 13:47:46 UTC 
Created attachment 188752 [details] [review]
Wrap function call and implementation

When compiling atk with ATK_DISABLE_DEPRECATED it's using the deprecated atk_hyperlink_is_selected_link() symbol. The prototype of this function is wrapped in #ifndef ATK_DISABLE_DEPRECATED, so wrap the callers accordingly.

Fix attached.
Comment 1 Jasper Lievisse Adriaanse 2011-05-30 08:13:31 UTC 
It turns out this patch breaks py-gtk2 so it makes me wonder where this API inconsistency comes from. Is the function deprecated or not?
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-05-30 10:25:51 UTC 
(In reply to comment #1)
> It turns out this patch breaks py-gtk2 so it makes me wonder where this API
> inconsistency comes from. Is the function deprecated or not?

Deprecated means that it shouldn't be used for new code, and eventually, it will be remove. If pygtk breaks is because it is using a deprecated function. So it is IMHO, a pygtk bug, something like "pygtk is using a deprecated function".
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-05-30 10:34:38 UTC 
(In reply to comment #0)
> Created an attachment (id=188752) [details] [review]
> Wrap function call and implementation
> 
> When compiling atk with ATK_DISABLE_DEPRECATED it's using the deprecated
> atk_hyperlink_is_selected_link() symbol. The prototype of this function is
> wrapped in #ifndef ATK_DISABLE_DEPRECATED, so wrap the callers accordingly.
> 
> Fix attached.

After review this patch I realized that it would be also good to mark as deprecated the property "selected-link", as it is providing the same info that this deprecated function.

Opinions? (Li?)

Anyway, if we don't deprecate the property, what we need to do on the get_property code is not wrap it. After all, if this function is deprecated, the first thing module that would start to not use it is ATK. So that call should be replaced by his replacement:

  Warning

  atk_hyperlink_is_selected_link is deprecated and should not be used in newly-written code. Please use ATK_STATE_SELECTED to indicate when a hyperlink within a Hypertext container is selected.
Comment 4 André Klapper 2011-06-23 22:07:05 UTC 
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 .
PLEASE NOTE:
If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla.
Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-12-11 12:36:35 UTC 
The property was deprecated while woking on bug 573539. This issue should be solved. Reopen if that is not the case.

*** This bug has been marked as a duplicate of bug 573539 ***